Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OLED] Cyrillic support & localization guide #1474

Closed
wants to merge 6 commits into from

Conversation

osmanovv
Copy link
Contributor

  • Cyrillic font for OLED
  • OLED localization guide

@CLAassistant
Copy link

CLAassistant commented May 29, 2022

CLA assistant check
All committers have signed the CLA.

@github-actions
Copy link
Contributor

github-actions bot commented May 29, 2022

🤖 Pull request artifacts

file commit
pr1474-firmware-1.2.65.ac60859.zip ac60859

thebentern added a commit to meshtastic/artifacts that referenced this pull request May 29, 2022
thebentern added a commit to meshtastic/artifacts that referenced this pull request May 30, 2022
@caveman99
Copy link
Member

I like this change, cause it has a low memory footprint if you don't define OLED_RU. Any chance we can get this for 1.3 as well? Would work fine with the new compression lib.

@caveman99
Copy link
Member

@osmanovv would you consider rebasing this PR to 1.3? 1.2 will only receive bugfixes, no new features.

@osmanovv
Copy link
Contributor Author

osmanovv commented Aug 5, 2022

@caveman99, so yes. I did not test it on v1.3, could it be cherry-picked to that branch?

@garthvh
Copy link
Member

garthvh commented Aug 12, 2022

could it be cherry-picked to that branch?

Using the edit link on the top of the pul to the right of the titlel you should be able to rebase the pull request from the 1.2 legacy branch to master by clicking edit and selecting master from the drop down.

@sachaw
Copy link
Member

sachaw commented Aug 20, 2022

@osmanovv looks like we'd be happy to merge this, but since 1.2 is about to be EOL'd, this needs to be rebased, also, the localization guide belongs in the docs: https://github.com/meshtastic/Meshtastic/tree/master/docs/developers/Firmware

@osmanovv osmanovv changed the base branch from 1.2-legacy to master August 22, 2022 13:04
@osmanovv osmanovv changed the base branch from master to 1.2-legacy August 22, 2022 13:07
@osmanovv
Copy link
Contributor Author

@sachaw , Localization guide has been extracted to doc: meshtastic/meshtastic#390

New PR for v1.3 is here: #1640

@osmanovv osmanovv closed this Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants