Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Air Quality values getting cut off #3751

Closed
HarukiToreda opened this issue Apr 30, 2024 · 4 comments
Closed

Enhancement: Air Quality values getting cut off #3751

HarukiToreda opened this issue Apr 30, 2024 · 4 comments

Comments

@HarukiToreda
Copy link
Contributor

HarukiToreda commented Apr 30, 2024

When Telemetry is turned on, the Air quality values are getting cut off at the bottom of the screen. I think reducing the header size will give enough room for this to show on smaller screens like on the Heltec V3.

20240430_000502

@todd-herbert
Copy link
Contributor

In EnvironmentTelemetry.cpp, it might be an idea to modify the drawFrame method, so that it checks display->height(). If the height is below some value, could then useFONT_SMALL everywhere FONT_MEDIUM is used?

@HarukiToreda
Copy link
Contributor Author

In EnvironmentTelemetry.cpp, it might be an idea to modify the drawFrame method, so that it checks display->height(). If the height is below some value, could then useFONT_SMALL everywhere FONT_MEDIUM is used?

Thank you, I think I have a working rough draft, I will wait for my other pull request to post the fix for this.

20240430_011336

@ponzano
Copy link

ponzano commented Apr 30, 2024

Very nice fix, thank you :)

@thebentern
Copy link
Contributor

Closed by #3785

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants