Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Add option to disable automatic nodeinfo requests from node #5238

Closed
aljaxus opened this issue Nov 3, 2024 · 5 comments · Fixed by #5242 or #5255
Closed

[Feature Request]: Add option to disable automatic nodeinfo requests from node #5238

aljaxus opened this issue Nov 3, 2024 · 5 comments · Fixed by #5242 or #5255
Assignees
Labels
enhancement New feature or request

Comments

@aljaxus
Copy link

aljaxus commented Nov 3, 2024

Platform

NRF52, ESP32, RP2040

Description

We have a small problem on our [slovenian] mesh where strategically positioned nodes (routers) have their nodedb filled up pretty fast. This means that nodes are getting removed when the limit (of 100) is reached.

This becomes a real problem when this node hears new packets (position/neighbourinfo/telemetry) from the nodes that it removed and since the node is not present in nodedb, it will sent its nodeinfo to the mesh (also requesting nodeinfo from the unknown node, resulting in two packets being sent over the mesh).

This cycle constantly repeats when you have more than 100 active nodes.

I think the responsible part of the code is in src/mesh/MeshService.cpp#89. A new setting would have to be added and an if statement checking that setting when attempting to automatically broadcast node information.

This change would only require a protobuf change in a single Config protobuf definition, in my opinion DeviceConfig would be a best fit.

@aljaxus aljaxus added the enhancement New feature or request label Nov 3, 2024
@thebentern thebentern self-assigned this Nov 3, 2024
@thebentern
Copy link
Contributor

After talking to @GUVWAF I think first order of business here is to probably remove the interrogation of unknown nodes from the Router role altogether, since they're not a traditional client. There's some other areas for optimization as well potentially

@aljaxus
Copy link
Author

aljaxus commented Nov 4, 2024

After talking to @GUVWAF I think first order of business here is to probably remove the interrogation of unknown nodes from the Router role altogether, since they're not a traditional client. There's some other areas for optimization as well potentially

Sure, but please also make it an option for normal client role devices. I have some strategically placed nodes that act as routers but have the client role.

@GUVWAF
Copy link
Member

GUVWAF commented Nov 4, 2024

I think we can also disable it when the NodeDB is full. In my opinion it doesn't sound like something that is worth a new setting.

@GUVWAF
Copy link
Member

GUVWAF commented Nov 4, 2024

I would like to keep this open and have a look at disabling the requests when the NodeDB is full.

@GUVWAF GUVWAF reopened this Nov 4, 2024
@GUVWAF GUVWAF self-assigned this Nov 4, 2024
@thebentern thebentern changed the title [Feature Request]: Add option to disable automatic neighbourinfo requests from node [Feature Request]: Add option to disable automatic nodeinfo requests from node Nov 4, 2024
@GUVWAF
Copy link
Member

GUVWAF commented Nov 4, 2024

See #5255.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
3 participants