Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Add an option to auto-delete stale nodes (inactive for x days) #5283

Closed
JurajKubrican opened this issue Nov 8, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@JurajKubrican
Copy link

Platform

Cross-Platform

Description

This relates to #5282 node db full

I believe a node can actually benefit from having a smaller node db.

On initial connection to the node, all nodes are being sent over a connection that can be slow/unreliable. this can lead to a slow / frustrating experience.

I believe adding an option to auto delete nodes that have not been heard for x days default week might improve the overall experience.

A similar feature has been added to the MeshSense SW which allows you to delete inactive nodes.

@JurajKubrican JurajKubrican added the enhancement New feature or request label Nov 8, 2024
@JurajKubrican JurajKubrican changed the title [Feature Request]: Add an option to delete nodes that have not been heard for x days [Feature Request]: Add an option to delete stale nodes (inactive for x days) Nov 8, 2024
@JurajKubrican JurajKubrican changed the title [Feature Request]: Add an option to delete stale nodes (inactive for x days) [Feature Request]: Add an option to auto-delete stale nodes (inactive for x days) Nov 8, 2024
@b8b8
Copy link

b8b8 commented Nov 8, 2024

Wouldn't that force re-exchanging keys unnecessarily when they come back into range and force rediscovery of nodes on the map that you would slowly lose the position of? The nodes are only passed on to the phone at initial connection, and while it takes a little time (a few seconds), I wouldn't say it is unreliable.

@thebentern
Copy link
Contributor

It introduces its own set of confusing issues and edge cases too... As a hypothetical, if I start up a device after months of inactivity, a TTL expiration for nodes in my NodeDB could cause all of my nodes to disappear.

@garthvh
Copy link
Member

garthvh commented Nov 8, 2024

You can already exclude the node db when connecting and there is an issue for a node only call #4564

@garthvh garthvh closed this as not planned Won't fix, can't repro, duplicate, stale Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants