Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: More robust muting, expand ignore_incoming array #5297

Closed
mdesmedt opened this issue Nov 10, 2024 · 5 comments
Closed

[Feature Request]: More robust muting, expand ignore_incoming array #5297

mdesmedt opened this issue Nov 10, 2024 · 5 comments
Labels
enhancement New feature or request

Comments

@mdesmedt
Copy link
Contributor

Platform

Cross-Platform

Description

I'm hoping Meshtastic firmware, and the clients, can support better muting (ignoring) for user-specified nodes. It is a configuration feature I would like to be able to use.

I am aware ignore_incoming exists, and it is exposed in the Android client, however the iOS client has previously decided against exposing this per meshtastic/Meshtastic-Apple#387 because it needs a reboot and maxes out at 3 entries. Addressing these limitations to make it a more usable end-user feature in addition to it being testing functionality would be appreciated.

@mdesmedt mdesmedt added the enhancement New feature or request label Nov 10, 2024
@garthvh
Copy link
Member

garthvh commented Nov 10, 2024

It does not reboot anymore, you are welcome to sponsor the feature on iOS, the array is probably not going to be expanded as you can't have arrays of dynamic size in protobufs.

@mdesmedt
Copy link
Contributor Author

I have, thanks to a suggestion, opted for an alternative approach where NodeInfo gets an is_ignored flag just like the is_favorite flag. This flag is checked in Router::perhapsHandleReceived and if set the packet is dropped.

I have tested my changes with two NRF52 devices and it works.

I am very new to open source but I will try to submit pull requests for the changes.

@thebentern
Copy link
Contributor

I am very new to open source but I will try to submit pull requests for the changes.

Well, it's a phenomenal first change. 😄

Are you on the Meshtastic discord server? I can get your contributor flair added if you send me your handle.

@mdesmedt
Copy link
Contributor Author

I am very new to open source but I will try to submit pull requests for the changes.

Well, it's a phenomenal first change. 😄

Are you on the Meshtastic discord server? I can get your contributor flair added if you send me your handle.

Thanks! I am anji0841 on Discord.

@mdesmedt
Copy link
Contributor Author

This is implemented in the firmware with commit 2ec3958

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants