Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Input field validation - Section Power #5335

Closed
Franselbaer opened this issue Nov 13, 2024 · 1 comment · Fixed by #5337
Closed

[Bug]: Input field validation - Section Power #5335

Franselbaer opened this issue Nov 13, 2024 · 1 comment · Fixed by #5337
Labels
bug Something isn't working

Comments

@Franselbaer
Copy link

Franselbaer commented Nov 13, 2024 •
edited
Loading

Category

Other

Hardware

Heltec V3

Firmware Version

2.5.11

Description

If you send an empty entry for the field "Shutdown on battery delay (seconds)" in power section via admin channel, the input field seems not to be validated but saved, which leads to constant reboot brick.

Should be set to "0" if empty (or unclear, e.g. not int 0-999999 or similar).

Relevant log output

None
@Franselbaer Franselbaer added the bug Something isn't working label Nov 13, 2024
@thebentern
Copy link
Contributor

0 is empty for this protobuf field. The firmware actually ignores it if it is not above zero. I can put some minimum value coercion in there but seems like you have a different issue occurring. Can you post your --info?

@thebentern thebentern mentioned this issue Nov 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Only allow 30 seconds minimum for power.on_battery_shutdown_after_secs meshtastic/firmware
2 participants
@thebentern @Franselbaer