Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: NMEA wpl sentences are broken now with the colorization of logs #5398

Closed
thebentern opened this issue Nov 19, 2024 · 2 comments · Fixed by #5412
Closed

[Bug]: NMEA wpl sentences are broken now with the colorization of logs #5398

thebentern opened this issue Nov 19, 2024 · 2 comments · Fixed by #5412
Assignees
Labels
bug Something isn't working

Comments

@thebentern
Copy link
Contributor

Category

Serial

Hardware

Not Applicable

Firmware Version

2.5.X

Description

Reported by Marc from CalTopo. We need to prefix sentenced with \r\n.

Relevant log output

No response

@thebentern thebentern added the bug Something isn't working label Nov 19, 2024
@thebentern thebentern self-assigned this Nov 19, 2024
@fifieldt
Copy link
Contributor

Just checking - is this a caltopo specific thing, or do they rely on output from GPS_DEBUG? If the latter, might be broken by more than just colorization.

@caveman99
Copy link
Member

Just checking - is this a caltopo specific thing, or do they rely on output from GPS_DEBUG? If the latter, might be broken by more than just colorization.

The GPS sentences are folded into the debug log but are independent of each other. This is also only true if you select to emit the serial module output over the debug port. default behaviour is to use a different serial port..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
3 participants