From 3c58decc688007ced730fbed22d05fec8631ea7e Mon Sep 17 00:00:00 2001 From: Ben Meadors Date: Thu, 28 Nov 2024 08:34:10 -0600 Subject: [PATCH 1/2] Don't log if keyboard not found --- src/input/cardKbI2cImpl.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/input/cardKbI2cImpl.cpp b/src/input/cardKbI2cImpl.cpp index b940f54483..eb9b07d6ec 100644 --- a/src/input/cardKbI2cImpl.cpp +++ b/src/input/cardKbI2cImpl.cpp @@ -49,10 +49,11 @@ void CardKbI2cImpl::init() kb_model = 0x00; } } - LOG_DEBUG("Keyboard Type: 0x%02x Model: 0x%02x Address: 0x%02x", kb_info.type, kb_model, cardkb_found.address); if (cardkb_found.address == 0x00) { disable(); return; + } else { + LOG_DEBUG("Keyboard Type: 0x%02x Model: 0x%02x Address: 0x%02x", kb_info.type, kb_model, cardkb_found.address); } } #else From 4951f2deb873d1eaf58a77034c1d33c930d935ab Mon Sep 17 00:00:00 2001 From: Ben Meadors Date: Thu, 28 Nov 2024 09:10:33 -0600 Subject: [PATCH 2/2] Signed comparison issue --- src/gps/GPS.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/gps/GPS.h b/src/gps/GPS.h index 74d73e39aa..15fc50fe7f 100644 --- a/src/gps/GPS.h +++ b/src/gps/GPS.h @@ -158,8 +158,8 @@ class GPS : private concurrency::OSThread uint32_t rx_gpio = 0; uint32_t tx_gpio = 0; - int speedSelect = 0; - int probeTries = 0; + uint8_t speedSelect = 0; + uint8_t probeTries = 0; /** * hasValidLocation - indicates that the position variables contain a complete @@ -239,4 +239,4 @@ class GPS : private concurrency::OSThread }; extern GPS *gps; -#endif // Exclude GPS +#endif // Exclude GPS \ No newline at end of file