Expose containerPort as $PORT_NAME env vars
#5888
Conversation
when using docker user networking (and not `hostPorts` exist). This part of code went missing from 1.3 to 1.4. JIRA: COPS-2072
| env += (s"PORT_${portName.toUpperCase}" -> effectivePort.toString) | ||
| // TODO(jdef) port name envvars for generated container ports | ||
| case (PortRequest(Some(portName), port), None) => |
There was a problem hiding this comment.
I'm building your change at jenkins-marathon-pipelines-PR-5888-1.
There was a problem hiding this comment.
✔ Build of #5888 completed successfully.
See details at jenkins-marathon-pipelines-PR-5888-1.
You can create a DC/OS with your patched Marathon by creating a new pull
request with the following changes in buildinfo.json:
"url": "https://s3.amazonaws.com/downloads.mesosphere.io/marathon/builds/marathon-1.6.0-pre-247-gb4ed634.tgz",
"sha1": "3654040793fe64972ac3763aea6ea9bea016a872"You can run system integration test changes of this PR against Marathon
master by triggering this Jenkins job with the Pull_Request_id 5888.
The job then reports back to this PR.
＼\ ٩( ᐛ )و /／
timcharper
force-pushed
the
master
branch
2 times, most recently
from
ce87c24
to
8aed882
Compare
- random container ports are now handled correctly
There was a problem hiding this comment.
I'm building your change at jenkins-marathon-pipelines-PR-5888-2.
There was a problem hiding this comment.
✗ Build of #5888 failed.
See the logs and test results for details.
Error message:
Stage Compile and Test failed.
(๑′°︿°๑)
There was a problem hiding this comment.
I'm building your change at jenkins-marathon-pipelines-PR-5888-3.
There was a problem hiding this comment.
✗ Build of #5888 failed.
See the logs and test results for details.
Error message:
Stage Compile and Test failed.
(๑′°︿°๑)
| assert("8080" == env("PORT_8080")) | ||
| assert("8080" == env("PORT_HTTP")) | ||
|
|
||
| val port1 = env("PORT1") |
There was a problem hiding this comment.
ditto re: sanity check that port1 ! = 0
There was a problem hiding this comment.
I'm building your change at jenkins-marathon-pipelines-PR-5888-4.
| import org.apache.mesos.Protos.TaskInfo | ||
| import org.apache.mesos.{ Protos => MesosProtos } |
There was a problem hiding this comment.
Looks like intelij and SBT have a different opinion on how to format imports :)
There was a problem hiding this comment.
✔ Build of #5888 completed successfully.
See details at jenkins-marathon-pipelines-PR-5888-4.
You can create a DC/OS with your patched Marathon by creating a new pull
request with the following changes in buildinfo.json:
"url": "https://s3.amazonaws.com/downloads.mesosphere.io/marathon/builds/marathon-1.6.0-pre-256-gb737b0d.tgz",
"sha1": "8bde77dace968b2e82fc2c6e1f886df1a982d5f6"You can run system integration test changes of this PR against Marathon
master by triggering this Jenkins job with the Pull_Request_id 5888.
The job then reports back to this PR.
＼\ ٩( ᐛ )و /／
|
lgtm the port-by-name docs could use some clarification/editing as well: https://github.com/mesosphere/marathon/blob/master/docs/docs/networking.md#per-task-environment-variables for example, PORT_name doesn't always refer to a host port. these variables are actually pretty confusing because their meaning changes depending upon how ports are allocated by an app. It might be worth a table that clearly shows how the value of the PORTxxx variables changes depending on the app configuration. |
when using docker user networking (and not
hostPortsexist). This part of code went missing from 1.3 to 1.4.JIRA: COPS-2072