This repository has been archived by the owner on Oct 23, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 5
graphql
signature diverges with standard graphql-js's one
#4
Labels
Comments
#6 can be added as divergent signature issue |
DanielMSchmidt
pushed a commit
that referenced
this issue
Jan 21, 2019
BREAKING CHANGE: All imports need to be `import {graphql}` instead of `import graphql` from now on Closes #4
DanielMSchmidt
pushed a commit
that referenced
this issue
Jan 21, 2019
BREAKING CHANGE: Its now schema, query instead of query, schema, so the inputs in all projects need to change Closes #4
DanielMSchmidt
pushed a commit
that referenced
this issue
Jan 21, 2019
DanielMSchmidt
pushed a commit
that referenced
this issue
Jan 22, 2019
BREAKING CHANGE: Its now schema, query instead of query, schema, so the inputs in all projects need to change Closes #4
DanielMSchmidt
pushed a commit
that referenced
this issue
Jan 22, 2019
🎉 This issue has been resolved in version 3.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
The common signature of the function
graphql
inreactive-graphql
differs fromgraphql-js
.With
graphql-js
the signature is roughly:While with
reactive-graphql
:Note the differences:
query
andschema
arguments position are invertedquery
is a string (or Source) in standard implementation and transformed inDocumentNode
in the implementation while in reactive version it expects aDocumentNode
directlycontext
is optionalThese differences are more or less minor, but wanted to know if they are intended or not, and thus if maintainer would be open to accepting a PR fixing this.
The text was updated successfully, but these errors were encountered: