Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix theme and colors for About and NewsBrainz Activities in Compose #176

Merged
merged 5 commits into from
Jun 12, 2023
Merged

Fix theme and colors for About and NewsBrainz Activities in Compose #176

merged 5 commits into from
Jun 12, 2023

Conversation

kingbass01
Copy link
Contributor

@kingbass01 kingbass01 commented Jun 9, 2023 •
edited
Loading

Ticket link - Fix theme and colors for About and NewsBrainz Activities in Compose

Before (Both Light and Dark Theme) :

About News

After:

About News
Light
Dark

@akshaaatt
Copy link
Member

akshaaatt commented Jun 10, 2023 •
edited
Loading

@kingbass01 awesome work! Can you please update the bg color for light theme as well? Also, some proper spacing between the app version number and stuff between contents could be better.
Also, do mention the ticket link in your description for the PR.

@kingbass01 kingbass01 closed this Jun 11, 2023
@kingbass01 kingbass01 force-pushed the fix157 branch 2 times, most recently from eca4d64 to 5cc5b09 Compare June 11, 2023 04:59
@kingbass01 kingbass01 reopened this Jun 11, 2023
@kingbass01
Copy link
Contributor Author

kingbass01 commented Jun 11, 2023 •
edited
Loading

@akshaaatt changes are done. Please take a look. Also:-
1- Please check whether the spacing is correct or not. I am not very good with UI/UX design.
2- The links in the About section are not clickable. We can implement that also.

I have also updated the screenshots.

Edit: I just found out that these screens look much better in the play store version, so do I need to replicate that only?

akshaaatt
akshaaatt approved these changes Jun 12, 2023
View reviewed changes
Copy link
Member

@akshaaatt akshaaatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kingbass01 I've made a few updates to the PR. Yes, we do want to replicate the playstore version style. Can you please work on this in another PR and update this further?

@akshaaatt akshaaatt merged commit 870fa40 into metabrainz:main Jun 12, 2023
@kingbass01
Copy link
Contributor Author

kingbass01 commented Jun 12, 2023 •
edited
Loading

Yeah sure.
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akshaaatt akshaaatt akshaaatt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kingbass01 @akshaaatt