Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format performsers splits "lead vocals" into "lead" and "vocals". #258

Open
phw opened this issue May 11, 2020 · 2 comments
Open

Format performsers splits "lead vocals" into "lead" and "vocals". #258

phw opened this issue May 11, 2020 · 2 comments

Comments

@phw
Copy link
Member

phw commented May 11, 2020

Using the "Format performer" tag loading e.g. https://musicbrainz.org/recording/e55e5bca-7fe2-436b-9afa-a5338fae32b6 the "lead vocal" relationship gets truend into two relationships, one for "lead" and one for "vocals". Same happens for "background vocals". I used the standard settings of the plugin

@rdswift Can you take a look?

@rdswift
Copy link
Contributor

rdswift commented May 11, 2020

I can't seem to reproduce it here using the new 0.7 version. Following are the settings I used (which I think are the defaults -- I pulled them from the code), and the results:

image

image

Can you please confirm the settings that you used and the results? Thanks.

@rdswift
Copy link
Contributor

rdswift commented May 11, 2020

Or are we thinking that there needs to be an option to treat "lead vocals" and "background vocals" each as their own keys rather than as a "vocals" key with "lead" and "background" descriptors, so they would be treated differently from other vocals like "soprano vocals"?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants