PICARD-2690: move const translations #2291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phw
force-pushed
the
PICARD-2690-move-locale-translations
branch
from
48161a6
to
b153ad2
Compare
phw
force-pushed
the
PICARD-2690-move-locale-translations
branch
from
b153ad2
to
f08e791
Compare
zas
previously approved these changes
Aug 24, 2023
phw
force-pushed
the
PICARD-2690-move-locale-translations
branch
from
dd04322
to
8428a17
Compare
This most prominently moves translations of dropdown lists for locales and writing systems into a separate component, making it easier to translate the main UI texts.
phw
force-pushed
the
PICARD-2690-move-locale-translations
branch
from
8428a17
to
cc7439e
Compare
rdswift
approved these changes
Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Problem
The
picard.constmodule contains longs lists, most specifically for locales and written scripts.This makes translating much harder, as half the strings to translate are from these lists, but they are essentially only used for very few UI elements.
Also it makes it difficult to assess how complete a translation of Picard is. A translations that translates all the UI texts except for the locale list has a low completion percentage on Weblate, but actually it is a very complete translation. Likewise a translation that solely translates the locales list shows with the same or higher completion, but actually the application can hardly be described as being localized.
Solution
Move translations of the strings in
picard.constinto a separate gettext message domain "picard-constants".I originally planned to move only the locales there, but with Babel it is easier to handle it by excluding a folder. And actually I think that fits well, as it also includes the scripts. Likewise I think it is no mistake to include the values in
picard/const/__init__.pyas well.There is a new setup command
picard_regen_constants_pot_file. We could also include a single meta command to update both, but for now I wanted to keep it separate (see below).Action
Of course we should keep existing translations. My plan was as follows:
picard.pot(removing the strings from it)picard.potandconstants/constants.potwith a single command