Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Uplift BMO to release-0.6 and IPAM to v1.7.0 #1605

Merged
merged 1 commit into from
Apr 18, 2024
Merged

🌱 Uplift BMO to release-0.6 and IPAM to v1.7.0 #1605

merged 1 commit into from
Apr 18, 2024

Conversation

mquhuy
Copy link
Member

@mquhuy mquhuy commented Apr 17, 2024

As titled
/hold

@metal3-io-bot metal3-io-bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 17, 2024
tuminoid
tuminoid reviewed Apr 17, 2024
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also bump hardwareutils from BMO to 0.6.0

@adilGhaffarDev
Copy link
Member

let's add IPAM uplift also on this PR once we have the release.

Sunnatillo
Sunnatillo reviewed Apr 17, 2024
View reviewed changes
Copy link
Member

@Sunnatillo Sunnatillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added lgtm Indicates that a PR is ready to be merged. and removed lgtm Indicates that a PR is ready to be merged. labels Apr 17, 2024
@mquhuy mquhuy force-pushed the mquhuy/uplift-bmo-to-release-0.6 branch 2 times, most recently from 0e180d8 to ffa2dff Compare April 18, 2024 10:35
@mquhuy
Copy link
Member Author

mquhuy commented Apr 18, 2024

/retitle 🌱 Uplift BMO to release-0.6 and IPAM to v1.7.0

@metal3-io-bot metal3-io-bot changed the title 🌱 Uplift BMO to release-0.6 🌱 Uplift BMO to release-0.6 and IPAM to v1.7.0 Apr 18, 2024
@mquhuy mquhuy force-pushed the mquhuy/uplift-bmo-to-release-0.6 branch from ffa2dff to 3dead62 Compare April 18, 2024 10:37
Sunnatillo
Sunnatillo reviewed Apr 18, 2024
View reviewed changes
Copy link
Member

@Sunnatillo Sunnatillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 18, 2024
@adilGhaffarDev
Copy link
Member

you need to uplift ipam in config/ipam/kustomization.yaml too.

@mquhuy mquhuy force-pushed the mquhuy/uplift-bmo-to-release-0.6 branch from 3dead62 to 2963d33 Compare April 18, 2024 10:48
@metal3-io-bot metal3-io-bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 18, 2024
adilGhaffarDev
adilGhaffarDev approved these changes Apr 18, 2024
View reviewed changes
Copy link
Member

@adilGhaffarDev adilGhaffarDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 18, 2024
@adilGhaffarDev
Copy link
Member

/unhold

@metal3-io-bot metal3-io-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 18, 2024
lentzi90
lentzi90 reviewed Apr 18, 2024
View reviewed changes
Copy link
Member

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adilGhaffarDev, lentzi90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 18, 2024
@metal3-io-bot metal3-io-bot merged commit 1a377bf into metal3-io:main Apr 18, 2024
15 checks passed
@metal3-io-bot metal3-io-bot deleted the mquhuy/uplift-bmo-to-release-0.6 branch April 18, 2024 10:58
@mquhuy
Copy link
Member Author

mquhuy commented Apr 18, 2024

/test ?

@mquhuy
Copy link
Member Author

mquhuy commented Apr 18, 2024

/test metal3-ubuntu-e2e-integration-test-main

@adilGhaffarDev adilGhaffarDev mentioned this pull request Apr 18, 2024
Closed
12 tasks
@adilGhaffarDev adilGhaffarDev mentioned this pull request Aug 13, 2024
Closed
50 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sunnatillo Sunnatillo Sunnatillo left review comments

@lentzi90 lentzi90 lentzi90 left review comments

@tuminoid tuminoid tuminoid left review comments

@adilGhaffarDev adilGhaffarDev adilGhaffarDev approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mquhuy @adilGhaffarDev @metal3-io-bot @tuminoid @lentzi90 @Sunnatillo