Validate config file schema #236
Conversation
|
@mikavilpas can you have a look? |
config.sample.yaml
Outdated
| @@ -1,4 +1,4 @@ | |||
| # yaml-language-server: $schema=./schema.json | |||
| # yaml-language-server: $schema=./config-file-schema.json | |||
There was a problem hiding this comment.
suggestion: could also use this to point to the latest schema version:
| # yaml-language-server: $schema=./config-file-schema.json | |
| # yaml-language-server: $schema=https://raw.githubusercontent.com/mfontanini/presenterm/master/config-file-schema.json |
I think the users that want to configure this can
- remove the entire comment if they prefer not using it
- change the URL to point to a different version, or even a local version
Note that this is not a permanent link; it always points to the latest master. Might require less user intervention this way.
There was a problem hiding this comment.
Yeah that's fair, this reduces the need to download extra files.
| current_schema=$(mktemp) | ||
| cargo run -q -- --generate-config-file-schema >"$current_schema" | ||
|
|
||
| diff=$(diff "${root_dir}/config-file-schema.json" "$current_schema") |
There was a problem hiding this comment.
suggestion: I'm not sure if it's worth doing, but could use diff --color=always -u to produce slightly more readable output.
(I saw that the build runner logs can display colored input)
There was a problem hiding this comment.
In practice I don't think this matters much but it doesn't hurt to add it 👌
mfontanini
force-pushed
the
validate-config-file-schema
branch
from
810790c to
3833ef2
Compare
This validates the config file JSON schema on every PR to ensure it's up to date.