Allow explicitly disabling footer in certain slides #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aitor
reviewed
Apr 22, 2024
|
|
||
| /// Whether we want a footer in the intro slide. | ||
| #[serde(default)] | ||
| pub(crate) footer: Option<bool>, |
There was a problem hiding this comment.
I was going to suggest renaming this to footer_on_intro or something like that, to make it more obvious that we are not skipping the footer always, just on the intro slide, but I've seen that this will be parsed from a YAML section that is already called intro_slide so it's clear that the setting only applies to that slide. No comments then! xD
mfontanini
force-pushed
the
disable-footer
branch
from
9628058 to
c0a7265
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows:
intro_slide.footerproperty tofalse.<!-- no_footer -->.Fixes #238