Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: block quotes lose underlying styles #341

Closed
calebdw opened this issue Aug 16, 2024 · 5 comments · Fixed by #350
Closed

bug: block quotes lose underlying styles #341

calebdw opened this issue Aug 16, 2024 · 5 comments · Fixed by #350

Comments

@calebdw
Copy link
Contributor

calebdw commented Aug 16, 2024

Hello!

It seems that block quotes lose any styles which might be inside the quote. For instance, given the following markdown:

> Here is a **blockquote**, which can be used to *emphasize* certain parts of your `presentation`.

here is how most software will render this:

Here is a blockquote, which can be used to emphasize certain parts of your presentation.

and here is how presenterm renders:

image

Thanks!

@mfontanini
Copy link
Owner

This isn't really a bug but a conscious decision I made while implementing this because I didn't have the tools to do this properly. Now after some recent changes, preserving the style should be simpler. I started implementing this but it's a bit trickier than I expected. I'll have a look at it this week a bit more.

@mfontanini
Copy link
Owner

@calebdw I created #350 to address this. Can you give it a shot and let me know if anything looks odd? The only thing that I'm aware of but unfortunately can't fix is multiple lines get truncated to 1:

> first
>
>
>
>
> last

Will be rendered as:

first

last

But it seems this is how the markdown parsing library I'm using delivers the AST to me so I don't think I can get around this. This issue exists in the current implementation anyway so it's not a new thing.

@calebdw
Copy link
Contributor Author

calebdw commented Aug 20, 2024

@mfontanini, thanks!

Sorry it took so long to respond, it's been busy at work.

The behavior is better, unfortunately it looks like the inline code is being ignored (no styles to presentation):

image

@mfontanini
Copy link
Owner

Dammit, I checked bold, underline, and strike through but didn't check inline code. Will fix tomorrow. Thanks for checking!

@mfontanini
Copy link
Owner

Fixed in #351

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants