-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug: block quotes lose underlying styles #341
Comments
This isn't really a bug but a conscious decision I made while implementing this because I didn't have the tools to do this properly. Now after some recent changes, preserving the style should be simpler. I started implementing this but it's a bit trickier than I expected. I'll have a look at it this week a bit more. |
@calebdw I created #350 to address this. Can you give it a shot and let me know if anything looks odd? The only thing that I'm aware of but unfortunately can't fix is multiple lines get truncated to 1: > first
>
>
>
>
> last Will be rendered as:
But it seems this is how the markdown parsing library I'm using delivers the AST to me so I don't think I can get around this. This issue exists in the current implementation anyway so it's not a new thing. |
@mfontanini, thanks! Sorry it took so long to respond, it's been busy at work. The behavior is better, unfortunately it looks like the inline code is being ignored (no styles to |
Dammit, I checked bold, underline, and strike through but didn't check inline code. Will fix tomorrow. Thanks for checking! |
Fixed in #351 |
Hello!
It seems that block quotes lose any styles which might be inside the quote. For instance, given the following markdown:
> Here is a **blockquote**, which can be used to *emphasize* certain parts of your `presentation`.
here is how most software will render this:
and here is how presenterm renders:
Thanks!
The text was updated successfully, but these errors were encountered: