feat: add +no_margin to remove margin in code blocks
#363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfontanini
added a commit
that referenced
this pull request
Sep 12, 2024
This renames the `no_margin` attribute added in #363 to `no_background` and makes it do everything `no_margin` did but also prevents presenterm from adding a background to the snippet. This currently doesn't play well with `exec_replace` or `exec` meaning the snippet execution output still gets background. I will address this separately as there's other things I want to get to but I want to close this issue. The following ~~~markdown ```text +no_background .__ .__ | |__ |__| _____ ____ _____ | | \| | / \ / _ \ / \ | Y \ | | Y Y ( <_> ) Y Y \ |___| /__| |__|_| /\____/|__|_| / \/ \/ \/ ``` ~~~ Currently renders like this after this change:  Fixes #349
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
+no_marginattribute to code blocks which removes extra margins. For themes that specify a vertical/horizontal padding (like all built in themes), the padding is still present even when using this. This only removes the margin that typically extends a bit right if your code snippet's max line length is too short.This is especially useful when using
+exec_replaceso you don't get any extra margin and instead get the executed program's output as-is. For example, the following now looks like this:Fixes #349