Undefined property: PhpParser\Node\Stmt\Property::$type

[if-owen]

I have been trying to set this up in my gitlab CI and also tried running this locally on my macbook, and in both circumstances I get a lot of notices thrown to the screen/console like this:

Macbook:

Notice: Undefined property: PhpParser\Node\Stmt\Property::$type in phar:///Users/xxxxxx/www.xxxxx.com/drupal-check.phar/vendor/nikic/php-parser/lib/PhpParser/NodeVisitor/NameResolver.php on line 98

Gitlab:

Notice: Undefined property: PhpParser\Node\Stmt\Property::$type in phar:///home/gitlab-runner/builds/e67c5a4b/0/xxxx/xxxx/drupal-check.phar/vendor/nikic/php-parser/lib/PhpParser/NodeVisitor/NameResolver.php on line 97

Any ideas what I may be doing wrong? In both circumstances we are using PHP 7.2

[mglaman]

So, with #9 we discovered there can be problems on custom projects. This might be due to PHP Mess Detector, Phan, Psalm, etc.

Can you:

• Tun composer show nikic/php-parser on your project?
• If it returns a version,
  • can you provide the version?
  • Run composer why nikic/php-parser

Drush requires psy/psysh for the PHP Shell. This uses the AST parser but allows any existing major version.

If not... I am not sure. We'd need to dig into your project's dependencies more.

[chx]

I can reproduce this. Here is the information requested:

versions : * v4.1.0

psy/psysh v0.9.9 requires nikic/php-parser (~1.3|~2.0|~3.0|~4.0)

Thanks for the super useful utility!

[mglaman]

phar:///Users/xxxxxx/www.xxxxx.com/drupal-check.phar

Is the Phar in your Drupal project's root? Can you try moving it into another directory and running it? Drupal Check is expecting v4.2.1. PHPStan only requires "^4.0.2". I wonder if Drupal Check needs a stronger constraint so it doesn't conflict with Drush.

psy/psysh may support ~4.0. But maybe the project only has 4.1 from when Drush was last updated. Now Drupal Check comes in expecting 4.2.1. But it adds Drupal's autoloader and now it's working with 4.1.0 and not 4.2.1.

[chx]

What I don't understand here and the vendor issue both: this is a phar file, why woud compontents outside of it matter? (Same goes for drush as well. I never studied PHAR much, I guess.)

[mglaman]

So there problem is this:

Phars are an archive, and the project's vendor is actually "zipped up" in the Phar. So it still runs Composer's autoloader inside of it.

In order to do static analysis, it needs to include the Drupal project's autoload.php and bootstrap Drupal's namespace/autoloading.

As soon as it loads Drupal.. any libraries from Drupal overwrite known namespace paths for Drupal Check.

[chx]

Reload phar autoload after?

[mglaman]

Focusing on this in #37.

tl;dr of problem:

This means any Drupal 8 project created before Drupal 8.5.0 (7 Mar 2018) probably has the v3 branch of the PHP-Parser.