Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support phpstan/phpstan 2.0 by creating a new 2.x branch of this fine extension #806

Closed
Boegie opened this issue Nov 12, 2024 · 5 comments
Closed
Labels
enhancement New feature or request

Comments

@Boegie
Copy link
Contributor

Boegie commented Nov 12, 2024

Feature request

https://github.com/phpstan/phpstan/releases/tag/2.0.1 is out.

Since it's not possible to support both 1.x and 2.x in one branch, according to the maintainer, we need a new 2.x branch

@Boegie Boegie added the enhancement New feature or request label Nov 12, 2024
@Boegie
Copy link
Contributor Author

Boegie commented Nov 12, 2024

See #805

@mglaman
Copy link
Owner

mglaman commented Nov 12, 2024

I wonder if main should become 2.x and just open 1.x off of main for PHPStan v1 support

@Boegie
Copy link
Contributor Author

Boegie commented Nov 12, 2024

That makes sense to me, since new development will mostly/only happen in main/2.x and maybe backported to 1.x I assume?

@mglaman
Copy link
Owner

mglaman commented Nov 12, 2024

yeah, everything will have to be backported vs forwarded

@mglaman
Copy link
Owner

mglaman commented Nov 12, 2024

Opened https://github.com/mglaman/phpstan-drupal/tree/1.x, main will be tracking 2.x of PHPStan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants