Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 6: lets you schedule job with missing arguments #351

Closed
mathieujobin opened this issue Nov 19, 2018 · 3 comments
Closed

Version 6: lets you schedule job with missing arguments #351

mathieujobin opened this issue Nov 19, 2018 · 3 comments

Comments

@mathieujobin
Copy link

Describe the bug
when perform as required arguments, sidekiq normally returns an error when calling perform_async without any arguments, this is no longer the case with sidekiq_unique_jobs 6.0.6

Expected behavior
the ArgumentError should be raised in the process calling perform_async

Current behavior
jobs is sent to sidekiq to crash.

Worker class

class MyWorker
  include Sidekiq::Worker
  sidekiq_options lock: :until_executed, queue: :undefault
  def perform(args); end

  def self.unique_args(args)
    # the way you consider unique arguments
  end
end
@mhenrixon
Copy link
Owner

This one is interesting, I thought I had tests for this. Would it be possible for you to provide a failing test for this?

@lairtonlelis
Copy link

Sidekiq never had that behavior. perform_async doesn't raise ArgumentError, even when called with a different number of arguments. The error actually occurs when the job is executed and perform is called.

@mhenrixon
Copy link
Owner

I'm closing this one to stay compatible with Sidekiq.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants