Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small changes #33

Merged
merged 1 commit into from
Jun 2, 2016
Merged

Small changes #33

merged 1 commit into from
Jun 2, 2016

Conversation

pawelczak
Copy link

Hi @michaelbromley ,

I started using your ng2-pagination and it turned out, that it is really useful for my project. Unfortunately I started to having some issues with pagination, so I needed to investigated what has caused them. It turned out, that problem was on my side :), but while I was running your project I found some issues.

@michaelbromley
Copy link
Owner

Thanks for the PR - the changes look good in general.

I'm wondering what the reason is for the npm postinstall script though. What problem does that solve?

@michaelbromley michaelbromley merged commit ed4105a into michaelbromley:master Jun 2, 2016
@pawelczak
Copy link
Author

@michaelbromley
postinstall runs automatically after npm install, so you don't have to remember to run typings installation.

@michaelbromley
Copy link
Owner

But why would a consumer of this package want to install the type defs, which are only used in development of the lib? In fact, the typings.json is not even exported in the npm package. Am I missing something?

@pawelczak
Copy link
Author

@michaelbromley
No, it's my mistake. postinstall is not needed.

@michaelbromley
Copy link
Owner

michaelbromley commented Jun 2, 2016

Ok, thanks for clearing that up. Otherwise, the rest of your fixes are now in version 0.3.1 on npm 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants