Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@Deprecated to work like @Ignore #47

Open
phillip-kruger opened this issue Aug 2, 2019 · 6 comments
Open

@Deprecated to work like @Ignore #47

phillip-kruger opened this issue Aug 2, 2019 · 6 comments
Labels
good first issue Good for newcomers
Milestone

Comments

@phillip-kruger
Copy link
Contributor

Add test cases for @deprecated and make sure that it can work the same as @ignore

Meaning that if placed on the field, both Input and Output is deprecated, however putting it on the getter of setter only the input or output is deprecated. (Same as @ignore)

@andymc12 andymc12 added this to the 1.0 milestone Aug 22, 2019
@andymc12
Copy link
Contributor

andymc12 commented Oct 2, 2019

This was considered a stretch goal for 1.0, but we're past the original cutoff date for 1.0, so I'm moving this to 1.1. We will need to remove the existing @Deprecated API annotation and spec text for 1.0 - I'll open a separate issue or that.

@phillip-kruger
Copy link
Contributor Author

Can this now move back to 1.0 ?

@andymc12
Copy link
Contributor

I'd say that we should leave it at 1.1 until we have a pull request ready to go before the 1.0 deadline (I reset that to be December 2).

@andymc12 andymc12 added the good first issue Good for newcomers label Jun 26, 2020
@t1
Copy link
Contributor

t1 commented Nov 11, 2020

Actually, I think things annotated as @Deprecated should not be simply ignored, but get the @deprecated directive instead.

@phillip-kruger
Copy link
Contributor Author

Yes, that is the idea, the "work like ignore" just means that we allow it on get and set and field, so it applies to output, input or both. We will also have our own annotation (that can take a reason) but will also support the java one.

@t1
Copy link
Contributor

t1 commented Feb 4, 2021

The new annotation could be implemented as a custom directive #344.

@phillip-kruger phillip-kruger modified the milestones: 1.1, 2.0 Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants