Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify usage of the name attribute of @Source #478

Open
jmartisk opened this issue Nov 7, 2022 · 3 comments
Open

Clarify usage of the name attribute of @Source #478

jmartisk opened this issue Nov 7, 2022 · 3 comments

Comments

@jmartisk
Copy link
Contributor

jmartisk commented Nov 7, 2022

The @Source annotation has a parameter name, the javadoc says it should denote the name of the added field. But the spec text doesn't mention this at all, and the TCK don't verify this either.

Another way to specify the name is to use a @Name annotation on the source method. We might need to clarify that both approaches are supported, and potentially specify which one takes priority?! (Or leave the behavior as "undefined" in case that both approaches are used at the same time)

@phillip-kruger
Copy link
Contributor

This should be consistent with other annotations. So no name attribute on @Source only value. And support for the @Name annotation.

@jmartisk
Copy link
Contributor Author

jmartisk commented Nov 9, 2022

There's no value attribute on @Source, only name.
Shall we deprecate the name attribute for removal? It would be tempting to remove it right away because it probably never worked for anybody, but if the next release is a minor (2.1) then I think we should still refrain from it.

@phillip-kruger
Copy link
Contributor

Yes I think so. And add the value attribute

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants