Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type helper time zone conversion does not take daylight saving into account #18995

Closed
PeterConijn opened this issue Jul 1, 2022 · 2 comments
Closed

Type helper time zone conversion does not take daylight saving into account #18995

PeterConijn opened this issue Jul 1, 2022 · 2 comments
Labels
extensibility-bug Something in the public APIs isn't working the way it should be

Comments

@PeterConijn
Copy link
Contributor

The procedures GetTimeZoneOffset and GetTimeZoneUserOffset offsets do not allow for daylight saving time.

image

This is because the conversion uses .BaseUtcOffset instead of .GetUtcOffset.
image

We need a procedure that calculates the correct offset based on a datetime argument like the example below:

image
@PeterConijn PeterConijn changed the title Type helper time zone converion does not take daylight saving into account Type helper time zone conversion does not take daylight saving into account Jul 1, 2022
@AlexanderYakunin AlexanderYakunin added the extensibility-bug Something in the public APIs isn't working the way it should be label Jul 4, 2022
@JesperSchulz
Copy link
Contributor

Looks like you're taking care of that issue by yourself now in PR #21246? 🥳 Should we close this issue then?

@PeterConijn
Copy link
Contributor Author

We should. I have good hope the PR might be accepted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
extensibility-bug Something in the public APIs isn't working the way it should be
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@JesperSchulz @AlexanderYakunin @PeterConijn