Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change build scripts from Nuget.exe to DotNet.exe #149

Closed
AdamBraden opened this issue Apr 16, 2020 · 3 comments · Fixed by #189
Closed

Change build scripts from Nuget.exe to DotNet.exe #149

AdamBraden opened this issue Apr 16, 2020 · 3 comments · Fixed by #189
Labels
fixed Issue has been fixed in an upcoming or existing release

Comments

@AdamBraden
Copy link
Contributor

nuget.exe is a separate download. Since we are building cswinrt projections, most folks will have the dotnet sdk installed. Switching over to dotnet.exe will avoid having an extra dependency that you need to download and place somewhere in the path

@Scottj1s
Copy link
Member

Scottj1s commented Apr 16, 2020

dotnet restore doesn't appear to support packages.config projects (C++), so I think nuget is still required.

dotnet/sdk#7922

@jkoritzinsky
Copy link
Member

Additionally, the dotnet CLI doesn't support C++ projects, so it wouldn't be able to restore the C++/WinRT projects' packages anyway.

@Scottj1s Scottj1s reopened this Apr 23, 2020
@Scottj1s
Copy link
Member

Otoh, we can certainly download nuget from the script to address that as a separate step

@angelazhangmsft angelazhangmsft added the fixed Issue has been fixed in an upcoming or existing release label May 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixed Issue has been fixed in an upcoming or existing release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants