Skip to content

Commit

Permalink
Bugfix: delete redundant validation of device availability (#314)
Browse files Browse the repository at this point in the history
  • Loading branch information
zhou9584 authored Mar 2, 2023
1 parent 8a9f4d6 commit 3d94ff2
Showing 1 changed file with 0 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -804,9 +804,6 @@ private JSONObject runTestTaskByGroup(TestTaskSpec testTaskSpec) {
Assert.isTrue(deviceSerials.size() > 0, "error deviceIdentifier or there is no devices in the group!");
DeviceGroup deviceGroup = deviceGroupService.getGroupByName(testTaskSpec.deviceIdentifier);
Assert.notNull(deviceGroup, "error deviceIdentifier !");
if (deviceGroup.getIsPrivate()) {
checkAccessInfo(testTaskSpec.deviceIdentifier, testTaskSpec.accessKey);
}
Map<String, List<String>> testAgentDevicesMap = new HashMap<>();
boolean isSingle = Const.DeviceGroup.SINGLE_TYPE.equals(testTaskSpec.groupTestType);
boolean isAll = Const.DeviceGroup.ALL_TYPE.equals(testTaskSpec.groupTestType);
Expand Down Expand Up @@ -865,9 +862,6 @@ private JSONObject runTestTaskByDevice(TestTaskSpec testTaskSpec) {
Message message = new Message();
message.setBody(testTaskSpec);
message.setPath(Const.Path.TEST_TASK_RUN);
if (device.getIsPrivate()) {
checkAccessInfo(device.getSerialNum(), testTaskSpec.accessKey);
}
Assert.isTrue(device.isAlive(), "Device/Agent Offline!");
if (device.isTesting()) {
return result;
Expand Down

0 comments on commit 3d94ff2

Please sign in to comment.