this pointer in <DisplayString> expands with extra {} inclusions
#1391
Labels
Comments
yh-sb
changed the title
int* expands with extra {} inclusionsthis pointer expands with extra {} inclusions
yh-sb
changed the title
this pointer expands with extra {} inclusionsthis pointer in <DisplayString> expands with extra {} inclusions
|
I did some digging, and I found the problem is present in visual studio too https://developercommunity.visualstudio.com/t/How-to-avoid-recursion-in-natvis-Display/404898. I guess it could be possible to break the recursion by adding something like this: --- a/src/MIDebugEngine/Natvis.Impl/Natvis.cs
+++ b/src/MIDebugEngine/Natvis.Impl/Natvis.cs
@@ -1216,7 +1216,13 @@ namespace Microsoft.MIDebugEngine.Natvis
Match m = s_expression.Match(format.Substring(i));
if (m.Success)
{
- string exprValue = GetExpressionValue(format.Substring(i + 1, m.Length - 2), variable, scopedNames);
+ string exprValue;
+ string expression = format.Substring(i + 1, m.Length - 2);
+ IVariableInformation expressionVariable = GetExpression(format.Substring(i + 1, m.Length - 2), variable, scopedNames);
+ if(expression == "this") // or maybe expressionVariable.TypeName == variable.TypeName
+ exprValue = expressionVariable.Value;
+ else
+ exprValue = FormatDisplayString(expressionVariable).value;
value.Append(exprValue);But it's tricky to get the exit condition right, and it may still not cover some corner cases. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Environment
Bug Summary and Steps to Reproduce
Bug Summary: Value visualization for
thispointer variables displays messy with the following natvis configuration. The issue is reproduced not only for int* type, but anytime ifthispointer is present in DisplayString natvis value.Source code:
Natvis file:
See
ptrvalue with lot of redundant{}:Expected result:
{ 0x2ee11ff6c4=5 }Debugger Configurations
// launch.json { "version": "0.2.0", "configurations": [ { "name": "g++ active file", "type": "cppdbg", "request": "launch", "program": "${fileDirname}/${fileBasenameNoExtension}", "cwd": "${fileDirname}", "miDebuggerPath": "gdb", "internalConsoleOptions": "neverOpen", "preLaunchTask": "g++ active file", "showDisplayString": true, "visualizerFile": "${workspaceFolder}/.vscode/test.natvis" } ] } // tasks.json { "tasks": [ { "label": "g++ active file", "command": "g++", "args": [ "-fdiagnostics-color=always", "-g", "-std=c++20", "${file}", "-o", "${fileDirname}/${fileBasenameNoExtension}" ], "options": { "cwd": "${fileDirname}" }, "problemMatcher": [ "$gcc" ], "group": { "kind": "build" }, "presentation": { "reveal": "silent" } } ], "version": "2.0.0" }Debugger Logs
DEBUG CONSOLE
Other Extensions
Issue persists when other extensions disabled
Additional Information
No response
The text was updated successfully, but these errors were encountered: