Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate properly designing _CONTAINER_DEBUG_LEVEL #586

Closed
Predelnik opened this issue Mar 4, 2020 · 4 comments
Closed

Investigate properly designing _CONTAINER_DEBUG_LEVEL #586

Predelnik opened this issue Mar 4, 2020 · 4 comments
Labels
duplicate This issue or pull request already exists enhancement Something can be improved

Comments

@Predelnik
Copy link

This is not an issue per se but from viewpoint of the users who disabled _ITERATOR_DEBUG_LEVEL in debug due to the way it affects parallel performance, more lightweight _CONTAINER_DEBUG_LEVEL seems to be very useful, providing just simple bounds checking etc. However I see that it's not documented as well as _ITERATOR_DEBUG_LEVEL and I wonder if defining it is a public, official feature and thus it's okay to use it or is it for internal use only? Also it'd be nice to see the scope of checks enabling it performs without looking at sources of course.

Feel free to close if I should create an issue somewhere like in https://github.com/MicrosoftDocs/cpp-docs about this instead.

@StephanTLavavej StephanTLavavej added decision needed We need to choose something before working on this documentation Related to documentation or comments labels Mar 4, 2020
@StephanTLavavej
Copy link
Member

Marking as decision needed because we're not really comfortable with the design and behavior of the feature, so we need a plan here.

@kdashg
Copy link

kdashg commented Dec 27, 2021

We are hoping to enable _CONTAINER_DEBUG_LEVEL=1 in Firefox, so I really hope we can rely on its functionality!
https://bugzilla.mozilla.org/show_bug.cgi?id=1746547

@StephanTLavavej StephanTLavavej removed the decision needed We need to choose something before working on this label Apr 26, 2023
@StephanTLavavej
Copy link
Member

We talked about this at the weekly maintainer meeting and decided that we're not comfortable enough with the (lack of) design of this feature to begin documenting it for wide usage.

We'll change this issue accordingly. This may be something we'll need to consider for vNext since it could have wide-reaching effects.

@StephanTLavavej StephanTLavavej added enhancement Something can be improved and removed documentation Related to documentation or comments labels Apr 26, 2023
@StephanTLavavej StephanTLavavej changed the title _CONTAINER_DEBUG_LEVEL documentation Investigate properly designing _CONTAINER_DEBUG_LEVEL Apr 26, 2023
@StephanTLavavej StephanTLavavej added the duplicate This issue or pull request already exists label Nov 20, 2024
@StephanTLavavej
Copy link
Member

Closing as a duplicate of the newer issue #5090.

@StephanTLavavej StephanTLavavej closed this as not planned Won't fix, can't repro, duplicate, stale Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists enhancement Something can be improved
Projects
None yet
Development

No branches or pull requests

3 participants