You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The x part of x: 'test' could be marked as strikethrough (x).
π» Use Cases
People that copy-paste code will never figure out that the property has been deprecated unless they hover the property which is very unlikely. Strikethrough would immediately indicate that the copy-pasted code contains a deprecated property.
The text was updated successfully, but these errors were encountered:
oldrich-s
changed the title
Deprecated property should be marked as strikeout
Deprecated property could be marked as strikeout
Aug 31, 2021
oldrich-s
changed the title
Deprecated property could be marked as strikeout
Deprecated property could be marked as strikethrough
Aug 31, 2021
For inside the playground? This would need to be added to monaco-typescript: https://github.com/microsoft/monaco-typescript - you're welcome to give it a shot. I'll move this issue to the TS website repo if that's what you're talking about?
My assumption is that is not just for playground (screenshot from VS Code)
If I understood correctly: Idea is to show deprecations for properties inside of object literal that is assigned/passed to place with type that has deprecated field.
I traced it to this._languageService.getSuggestionDiagnostics(fileName); which only returns diagnostics for a.longerName; // marked as deprecated but not for longerName: 'test'.
Suggestion
π Search Terms
deprecated strike
β Viability Checklist
My suggestion meets these guidelines:
β Suggestion
π Motivating Example
https://www.typescriptlang.org/play?#code/C4TwDgpgBAGlC8UDeAoK6oHoBU2oAEATCMAJwgGMBDYCQqbTNDADwC4oBnYUgSwDsA5igC+KFADMArvwrBeAe35QJygBQA3DjACUycWMn81SKOygByWtwtQROoA
The
x
part ofx: 'test'
could be marked as strikethrough (x).π» Use Cases
People that copy-paste code will never figure out that the property has been deprecated unless they hover the property which is very unlikely. Strikethrough would immediately indicate that the copy-pasted code contains a deprecated property.
The text was updated successfully, but these errors were encountered: