Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple assertions on a single function #49728

Closed
5 tasks done
sagi-arbroknot opened this issue Jun 29, 2022 · 2 comments
Closed
5 tasks done

Multiple assertions on a single function #49728

sagi-arbroknot opened this issue Jun 29, 2022 · 2 comments
Labels
Duplicate An existing issue was already created

Comments

@sagi-arbroknot
Copy link

sagi-arbroknot commented Jun 29, 2022

Suggestion

πŸ” Search Terms

assert, assertion, type guard

βœ… Viability Checklist

My suggestion meets these guidelines:

  • This wouldn't be a breaking change in existing TypeScript/JavaScript code
  • This wouldn't change the runtime behavior of existing JavaScript code
  • This could be implemented without emitting different JS based on the types of the expressions
  • This isn't a runtime feature (e.g., library functionality, non-ECMAScript syntax with JavaScript output, new syntax sugar for JS, etc.)
  • This feature would agree with the rest of TypeScript's Design Goals.

⭐ Suggestions

Working with multiple assertion guards.

πŸ“ƒ Motivating Example

private assertWebhook(
      hostname: string,
      ip: string,
      query: Record<string, any> | undefined,
      body: Record<string, any> | Record<string, any>[] | undefined,
): asserts query, assert body

πŸ’» Use Cases

Having a single function/method that allows multiple assertions.
The current approach doesn't allow multiple assertion guards.
I must create a function for each assertion individually
and return the asserted value with their perspective types.

@MartinJohns
Copy link
Contributor

Duplicate of #42253.

@RyanCavanaugh RyanCavanaugh added the Duplicate An existing issue was already created label Jun 29, 2022
@typescript-bot
Copy link
Collaborator

This issue has been marked as a 'Duplicate' and has seen no recent activity. It has been automatically closed for house-keeping purposes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Duplicate An existing issue was already created
Projects
None yet
Development

No branches or pull requests

4 participants