Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-3.3] Supports incremental build in tsc --b --w mode #29467

Merged
merged 21 commits into from
Jan 17, 2019
Merged

[release-3.3] Supports incremental build in tsc --b --w mode #29467

merged 21 commits into from
Jan 17, 2019

Commits on Jan 17, 2019

  1. Use watch factory instead of direct host functions in tsbuild to prov… 

    …ide detailed information on watch invokations
    @sheetalkamat
    sheetalkamat committed Jan 17, 2019
    Configuration menu
    Copy the full SHA
    8d2c359 View commit details
    Browse the repository at this point in the history

  2. Make BuilderProgram as Program

    @sheetalkamat
    sheetalkamat committed Jan 17, 2019
    Configuration menu
    Copy the full SHA
    9fcfa28 View commit details
    Browse the repository at this point in the history

  3. Make SolutionBuilder handle BuilderProgram in preparation to handle i… 

    …ncremental builds
    @sheetalkamat
    sheetalkamat committed Jan 17, 2019
    Configuration menu
    Copy the full SHA
    5d6ecb5 View commit details
    Browse the repository at this point in the history

  4. Revert BuilderProgram to be redirected object to Program in preparati… 

    …on to set Program in state to undefined for storing.
    @sheetalkamat
    sheetalkamat committed Jan 17, 2019
    Configuration menu
    Copy the full SHA
    900dc8c View commit details
    Browse the repository at this point in the history

  5. Add method to release held Program in BuilderProgram

    @sheetalkamat
    sheetalkamat committed Jan 17, 2019
    Configuration menu
    Copy the full SHA
    b6e6b99 View commit details
    Browse the repository at this point in the history

  6. Use oldProgram to create the new Program. 

    This helps in storing the semantic diagnostics
    @sheetalkamat
    sheetalkamat committed Jan 17, 2019
    Configuration menu
    Copy the full SHA
    2d712e3 View commit details
    Browse the repository at this point in the history

  7. Use emit builder to emit only changed files.

    @sheetalkamat
    sheetalkamat committed Jan 17, 2019
    Configuration menu
    Copy the full SHA
    6be4439 View commit details
    Browse the repository at this point in the history

  8. Update the timestamps of outputs that dont need to be written because… 

    … of incremental build

This ensures that after `tsbuild` after incremental build of `tsbuild -w` doesnt result in unnecessary rebuilds
    @sheetalkamat
    sheetalkamat committed Jan 17, 2019
    Configuration menu
    Copy the full SHA
    e00df32 View commit details
    Browse the repository at this point in the history

  9. Handle prepend in incremental build. Always emit when program uses pr… 

    …oject reference with prepend since it cant tell changes in js/map files
    @sheetalkamat
    sheetalkamat committed Jan 17, 2019
    Configuration menu
    Copy the full SHA
    122339b View commit details
    Browse the repository at this point in the history

  10. Write the tests for incremental build and declaration emit errors han… 

    …dling

These will fail since its still TODO
    @sheetalkamat
    sheetalkamat committed Jan 17, 2019
    Configuration menu
    Copy the full SHA
    82f8411 View commit details
    Browse the repository at this point in the history

  11. Handle declaration emit errors in tsbuild mode by backing up builder … 

    …state

This helps us revert to state where we pretend as if emit is not done (since we do not do emit if there are errors)
    @sheetalkamat
    sheetalkamat committed Jan 17, 2019
    Configuration menu
    Copy the full SHA
    75e2e2e View commit details
    Browse the repository at this point in the history

  12. Use DirectoryStructureHost for fileExists and readFile

    @sheetalkamat
    sheetalkamat committed Jan 17, 2019
    Configuration menu
    Copy the full SHA
    66018ea View commit details
    Browse the repository at this point in the history

  13. Fix typo

    @sheetalkamat
    sheetalkamat committed Jan 17, 2019
    Configuration menu
    Copy the full SHA
    1470a7c View commit details
    Browse the repository at this point in the history

  14. Rename indexing variable

    @sheetalkamat
    sheetalkamat committed Jan 17, 2019
    Configuration menu
    Copy the full SHA
    19cec03 View commit details
    Browse the repository at this point in the history

  15. CompilerHostLikeForCache rename

    @sheetalkamat
    sheetalkamat committed Jan 17, 2019
    Configuration menu
    Copy the full SHA
    72069a7 View commit details
    Browse the repository at this point in the history

  16. Fix typo

    @sheetalkamat
    sheetalkamat committed Jan 17, 2019
    Configuration menu
    Copy the full SHA
    2b97802 View commit details
    Browse the repository at this point in the history

  17. Fix typo

    @sheetalkamat
    sheetalkamat committed Jan 17, 2019
    Configuration menu
    Copy the full SHA
    dcce3c3 View commit details
    Browse the repository at this point in the history

  18. PR feedback

    @sheetalkamat
    sheetalkamat committed Jan 17, 2019
    Configuration menu
    Copy the full SHA
    0427ad0 View commit details
    Browse the repository at this point in the history

  19. PR feedback

    @sheetalkamat
    sheetalkamat committed Jan 17, 2019
    Configuration menu
    Copy the full SHA
    5a368ae View commit details
    Browse the repository at this point in the history

  20. add missing type annotation

    @sheetalkamat
    sheetalkamat committed Jan 17, 2019
    Configuration menu
    Copy the full SHA
    a93b51a View commit details
    Browse the repository at this point in the history

  21. renames

    @sheetalkamat
    sheetalkamat committed Jan 17, 2019
    Configuration menu
    Copy the full SHA
    3921921 View commit details
    Browse the repository at this point in the history