Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Awaited<T> inference #49748

Merged
merged 1 commit into from
Jul 1, 2022

Conversation

rbuckton
Copy link
Member

This addresses an issue where we are potentially too aggressive when unwrapping a promise-like type when inferring the return type of an async function from its function body.

Fixes #48320

@typescript-bot typescript-bot added Author: Team For Milestone Bug PRs that fix a bug with a specific milestone labels Jun 30, 2022
@rbuckton
Copy link
Member Author

@typescript-bot test this
@typescript-bot user test this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jun 30, 2022

Heya @rbuckton, I've started to run the extended test suite on this PR at 66a9169. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jun 30, 2022

Heya @rbuckton, I've started to run the diff-based user code test suite on this PR at 66a9169. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

@rbuckton
Great news! no new errors were found between main..refs/pull/49748/merge

@typescript-bot
Copy link
Collaborator

Heya @rbuckton, I've run the RWC suite on this PR - assuming you're on the TS core team, you can view the resulting diff here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author: Team For Milestone Bug PRs that fix a bug with a specific milestone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot auto indicate return type
3 participants