Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move RegExp flag version mapping to LanguageFeatureMinimumTarget #58311

Merged
merged 6 commits into from
Apr 25, 2024

Conversation

jakebailey
Copy link
Member

Not pressing, but this is a follow-up to #55600 to move the feature listing to the single enum we're now using to track features.

@jakebailey jakebailey requested a review from rbuckton April 24, 2024 21:50
@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Apr 24, 2024
src/compiler/scanner.ts Outdated Show resolved Hide resolved
src/compiler/types.ts Outdated Show resolved Hide resolved
src/compiler/types.ts Outdated Show resolved Hide resolved
]);

function getRegExpFlagToFirstAvailableLanguageVersion(flag: RegularExpressionFlags) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of this may be a change this function to do:

const availableFrom = getRegExpFlagToFirstAvailableLanguageVersion(flag);
                        if (availableFrom && languageVersion < availableFrom) {
                            error(Diagnostics.This_regular_expression_flag_is_only_available_when_targeting_0_or_later, p, 1, getNameOfScriptTarget(availableFrom));
                        }

@jakebailey jakebailey merged commit 8d2e2d5 into microsoft:main Apr 25, 2024
28 checks passed
@jakebailey jakebailey deleted the language-minimum-target branch April 25, 2024 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants