Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow declarationMap to be emitted when transpiling declarations and option is enabled #59337

Merged
merged 2 commits into from
Jul 18, 2024

Conversation

sheetalkamat
Copy link
Member

Fixes #59313

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@e7e8135). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #59337   +/-   ##
=======================================
  Coverage        ?   94.07%           
=======================================
  Files           ?      587           
  Lines           ?   300852           
  Branches        ?     5082           
=======================================
  Hits            ?   283023           
  Misses          ?    12747           
  Partials        ?     5082           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DanielRosenwasser
Copy link
Member

Should this be picked back to 5.5?

@jakebailey
Copy link
Member

Probably?

@sheetalkamat sheetalkamat merged commit afa03f0 into main Jul 18, 2024
30 checks passed
@sheetalkamat sheetalkamat deleted the transpileDeclarations branch July 18, 2024 00:07
@sheetalkamat sheetalkamat added this to the TypeScript 5.5.4 milestone Jul 18, 2024
@sheetalkamat
Copy link
Member Author

@typescript-bot cherry-pick this to release-5.5

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jul 18, 2024

Starting jobs; this comment will be updated as builds start and complete.

Command Status Results
cherry-pick this to release-5.5 ✅ Started ✅ Results

@typescript-bot
Copy link
Collaborator

Hey, @sheetalkamat! I've created #59344 for you.

DanielRosenwasser pushed a commit that referenced this pull request Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[transpileDeclaration API] ts.transpileDeclaration always returns empty sourceMapText
6 participants