Fixed #89: Ensured EventTriggerBehavior supports x:Bind bindings #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ings For x:Bind to work with EventTriggerbehavior, we need to ensure that no exception gets raised for not finding the request event on the source object, as this will might (will) get evaluate at a later phase. So instead of raising an exception, we just gracefully return from the method.
|
LGTM |
|
I agree. I didn't see this at first, but although I do not like silent fails, trading a silent fail that might occur for incorrect exceptions that will almost certainly occur seems like a good one |
LocalJoost
added a commit
that referenced
this pull request
Feb 25, 2016
Fixed #89: Ensured EventTriggerBehavior supports x:Bind bindings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For x:Bind to work with EventTriggerbehavior, we need to ensure that no exception gets raised for not finding the request event on the source object, as this will might (will) get evaluate at a later phase.
So instead of raising an exception, we just gracefully return from the method.