Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icons Not Showing For Associated Files #558

Closed
Stuart-Wilcox opened this issue Nov 28, 2023 · 3 comments · Fixed by #563
Closed

Icons Not Showing For Associated Files #558

Stuart-Wilcox opened this issue Nov 28, 2023 · 3 comments · Fixed by #563
Labels
Area: VsCodeExtension bug Something isn't working

Comments

@Stuart-Wilcox
Copy link

Stuart-Wilcox commented Nov 28, 2023

I recently installed the extension and all the files for which I setup associations are not showing an icon based on the filetype.

Ex.
image

When I force reloading of the window, I see this small failure pop-up
image

Cannot read properties of undefined (reading 'label')

Which I'm assuming is some sort of config issue.

This is not keeping the extension from working, but it is annoying and ugly.

@aleksandrlevochkin aleksandrlevochkin added bug Something isn't working and removed triage labels Nov 29, 2023
@aleksandrlevochkin
Copy link

Hi @Stuart-Wilcox, thanks for bringing this issue up. We are working on higher prioritized tasks at the moment, but we will get back to this one as soon as possible.

@Stuart-Wilcox
Copy link
Author

Thanks for the acknowledgment. Is there anything I can do in the meantime to try to debug myself?

@winstliu
Copy link
Member

winstliu commented Dec 27, 2023

No icon is expected (I'm not quite sure how to fix that, it might be up to icon packs to add a relevant icon?).
The label issue is interesting. I'm going to optimistically say that I fixed it in #553 which hasn't been released yet.
(Sidenote: I need to figure out how to make those error messages more useful.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: VsCodeExtension bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants