Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heading misalignment with markdown rendering in notebook #18678

Open
caohai opened this issue Mar 8, 2022 · 2 comments
Open

Heading misalignment with markdown rendering in notebook #18678

caohai opened this issue Mar 8, 2022 · 2 comments
Assignees
Labels
Area - Notebooks Bug Subarea - MD Rendering Triage: Done Triage: Postponed Items that were planned for a release but didn't make it for one reason or another.
Milestone

Comments

@caohai
Copy link
Member

caohai commented Mar 8, 2022

Version: 1.36.0 insider

Steps to Reproduce:

  1. Open a new notebook
  2. Paste something like this into a text cell with Markdown view:
## Sub1
- a
## Sub2
## Sub3

Notice that Sub2 and Sub3 are not correctly aligned.
image
The same md doc can be correctly rendered by VSCode and Github, example:

Sub1

  • a

Sub2

Sub3

image

PS: This can be worked around by adding an extra new line before the heading.

@chlafreniere chlafreniere added the Triage: Postponed Items that were planned for a release but didn't make it for one reason or another. label Jun 6, 2022
@chlafreniere
Copy link
Contributor

This has been fixed in markedjs/marked#2483, and released as marked.js 4.0.17.

This will eventually make its way into our codebase with vscode merges. Unfortunately, the version of marked.js is too old in the ADS codebase, so I can't just port this one fix without a decent amount of rework.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area - Notebooks Bug Subarea - MD Rendering Triage: Done Triage: Postponed Items that were planned for a release but didn't make it for one reason or another.
Projects
None yet
Development

No branches or pull requests

2 participants