Skip to content
This repository has been archived by the owner on Nov 16, 2023. It is now read-only.

replace tslint with eslint for repo itself #318

Merged
merged 2 commits into from
Mar 25, 2021

Conversation

43081j
Copy link
Contributor

@43081j 43081j commented Jan 1, 2021

I opened #305 ages back to move dtslint off tslint completely, as it has been deprecated for a very long time now.

however that turned out to be a huge task so im just trying to split it up a bit.

this PR moves the repo itself to being linted by eslint rather than tslint, but leaves the source roughly the same (using tslint).

some notes:

  • i turned off any rules your sources conflict with often (assuming they are just the chosen conventions for this repo)
  • there's a few switch fall throughs, on purpose it seems so i just ignored those
  • i turned off the recommended rule 'no-explicit-any' but maybe we should consider using unknown more etc or strongly typing those any uses

@43081j 43081j requested a review from sandersn as a code owner January 1, 2021 16:58
Copy link
Member

@sandersn sandersn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a good start. I'll merge shortly.

@sandersn sandersn merged commit 8ec7ef4 into microsoft:master Mar 25, 2021
@43081j
Copy link
Contributor Author

43081j commented Mar 26, 2021

Great, thanks a lot for taking time to pick it up and get it merged 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants