Skip to content
This repository has been archived by the owner on Nov 16, 2023. It is now read-only.

Adds a message telling you to npm install when there's missing deps #319

Merged
merged 3 commits into from
Feb 10, 2021

Conversation

orta
Copy link
Contributor

@orta orta commented Feb 10, 2021

Should make the next step very obvious if you hit DefinitelyTyped/DefinitelyTyped#24788

@orta orta requested a review from sandersn as a code owner February 10, 2021 18:06
@orta
Copy link
Contributor Author

orta commented Feb 10, 2021

Looks like:

/Users/ortatherox/dev/typescript/DefinitelyTyped/types/gatsby-plugin-breakpoints
Error: A module look-up failed, the most common case for this error a dependencies which needs to be `npm installed`.
        
Before you debug, first try running: 
   npm install --prefix types/react

Then re-run. Full error logs are below.

Errors in [email protected] for external dependencies:
../react/index.d.ts(38,22): error TS2307: Cannot find module 'csstype' or its corresponding type declarations.

    at /Users/ortatherox/dev/typescript/dtslint/bin/index.js:207:19
    at Generator.next (<anonymous>)
    at fulfilled (/Users/ortatherox/dev/typescript/dtslint/bin/index.js:6:58)

Copy link
Member

@sandersn sandersn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this workaround!

src/lint.ts Outdated Show resolved Hide resolved
@orta
Copy link
Contributor Author

orta commented Feb 10, 2021

Gonna drop travis in an upcoming PR, GH Actions shows green.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants