Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[data-grid]: focus and keyboard navigation also includes the header row #6622

Closed
YonatanKra opened this issue Jan 28, 2023 · 5 comments
Closed
Assignees
Labels
area:fast-foundation Pertains to fast-foundation compliance:a11y Accessibility compliance. status:needs-investigation Needs additional investigation

Comments

@YonatanKra
Copy link

When focusing in the data-grid, the header row's cells are focusable and navigatable:
image

According to W3C example, it is not so:
https://www.w3.org/WAI/ARIA/apg/example-index/grid/dataGrids.html

Is the discrepancy intended?

@chrisdholt chrisdholt added status:needs-investigation Needs additional investigation area:fast-foundation Pertains to fast-foundation compliance:a11y Accessibility compliance. labels Mar 1, 2023
@scomea
Copy link
Collaborator

scomea commented Mar 1, 2023

The "Minimal Data Grid" sample says "Since the header cells do not provide any functionality, they are not focusable.". The following example "Sortable Data Grid With Editable Cells" does have focusable headers which support the sorting functionality.

image

I think focusable headers is a useful feature, but I'd agree that there should be an option to make header rows not focusable.

@YonatanKra
Copy link
Author

I actually opened an issue with W3C.

They agreed a focusable header should be the go-to (we focused on a11y).

w3c/aria-practices#2626

@scomea
Copy link
Collaborator

scomea commented Mar 1, 2023

Ok, works for me. So, unless someone wants to argue for the ability to have non-focusable cells/rows we can close?

@YonatanKra
Copy link
Author

Yea. I actually implemented it (non-focusable headers) so if at any point in time it is needed, I can push a PR :)

@scomea
Copy link
Collaborator

scomea commented Mar 1, 2023

Yea. I actually implemented it (non-focusable headers) so if at any point in time it is needed, I can push a PR :)

More contributors is a good thing. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:fast-foundation Pertains to fast-foundation compliance:a11y Accessibility compliance. status:needs-investigation Needs additional investigation
Projects
None yet
Development

No branches or pull requests

3 participants