Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DetailsList ARIA attributes are not allowed #16144

Closed
sereymonyros opened this issue Dec 4, 2020 · 6 comments
Closed

DetailsList ARIA attributes are not allowed #16144

sereymonyros opened this issue Dec 4, 2020 · 6 comments

Comments

@sereymonyros
Copy link

sereymonyros commented Dec 4, 2020

Run accessibility insights app in DetailsList
Actual result: ARIA attributes are not allowed: aria-setsize="10", aria-posinset="1"
Expected result: should not see any accessibility issue at all
Repro: https://codepen.io/justslone-the-encoder/pen/vYXGJPM

Screenshot below:

image
image

@ecraig12345 ecraig12345 changed the title <DetailsList ARIA attributes are not allowed DetailsList ARIA attributes are not allowed Dec 4, 2020
@JustSlone JustSlone added Area: Accessibility Component: DetailsList Fluent UI react (v8) Issues about @fluentui/react (v8) Needs: Investigation The Shield Dev should investigate this issue and propose a fix and removed Needs: Triage 🔍 labels Dec 6, 2020
@JustSlone
Copy link
Collaborator

@sereymonyros thanks for filing this

Confirmed repro. Here's an isolated codepen: https://codepen.io/justslone-the-encoder/pen/vYXGJPM

So, this one is a bit complicated.
In this case DetailsList is behaving more as a treegrid, and actually the absence of being able to use aria-setsize and aria-posinset was an omission from the ARIA 1.1 spec. See this issue for more info

Actually if you try out accessibility insights on the official treegrid examples it raises the same issues.
https://www.w3.org/TR/wai-aria-practices-1.1/examples/treegrid/treegrid-1.html
image

So, I'm tempted to say this is expected and OK, however, my one reservation is that DetailsList, even though it's behaving like a treegrid, is actually role="grid".

@smhigley, You've had some thoughts or perspective on DetailsList's confused nature here, what are your thoughts on this issue?

@ms-kykwon
Copy link

ms-kykwon commented Apr 23, 2021

@JustSlone @dzearing Any luck on this issue?

@JustSlone
Copy link
Collaborator

@ms-kykwon, I believe this was fixed by another change. I'm not seeing repro anymore.

@smhigley might know more.

I am seeing an error on the group selection checkbox, but that's a different issue.

@JustSlone JustSlone added Needs: Author Feedback and removed Needs: Discussion Needs: Investigation The Shield Dev should investigate this issue and propose a fix labels Apr 27, 2021
@ecraig12345
Copy link
Member

Group selection checkbox issue is tracked by #13385

@smhigley
Copy link
Contributor

Both those issues should be resolved; I think this one can just be closed now, via #17300, and I'll go comment on the separate checkbox issue.

@ecraig12345 ecraig12345 added the Status: Fixed Fixed in some PR label Apr 27, 2021
@ms-kykwon
Copy link

@JustSlone @ecraig12345 @smhigley GroupedList have a similar issue. Would you take a look at it, please? #17943

@microsoft microsoft locked as resolved and limited conversation to collaborators May 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants