Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Customize boundary for dialog #33321

Open
1 task done
YuanboXue-Amber opened this issue Nov 21, 2024 · 0 comments
Open
1 task done

[Feature]: Customize boundary for dialog #33321

YuanboXue-Amber opened this issue Nov 21, 2024 · 0 comments

Comments

@YuanboXue-Amber
Copy link
Contributor

YuanboXue-Amber commented Nov 21, 2024

Area

React Components (@fluentui/react-components)

Describe the feature that you would like added

Dialog boundary is not customzible. There is no features like overflowPadding as in Popover/Menu. In my use case, I want to make dialog not intersect with the titlebar of my page.

In my use case, I have fluent dialog in my repo and from external library as well. A possible approach that will work for both my dialog and external dialog can be: create a context in Dialog component that provides a boundary type DialogBoundaryContext = HTMLElement | { getBoundingClientRect: () => { x: number; y: number; ... } }. And in DialogSurface consumes this context, calculate the top/left value of the dialog to position it.

Additional context

No response

Have you discussed this feature with our team

@microsoft/teams-prg

Validations

  • Check that there isn't already an issue that requests the same feature to avoid creating a duplicate.

Priority

Medium

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants