Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Dialog overflow handling seems off on small viewports (e.g iPhone) #33382

Open
2 tasks done
fruhnow opened this issue Dec 2, 2024 · 3 comments
Open
2 tasks done

Comments

@fruhnow
Copy link

fruhnow commented Dec 2, 2024

Component

Dialog

Package version

9.56.3

React version

18.3.1

Environment

System:
    OS: macOS 15.1.1
    CPU: (8) arm64 Apple M2
    Memory: 138.34 MB / 24.00 GB
    Shell: 5.9 - /bin/zsh
  Browsers:
    Chrome Canary: 133.0.6872.0
    Safari: 18.1.1
  npmPackages:
    @fluentui/react-components: ^9.56.3 => 9.56.3 
    @types/react: ^18.3.12 => 18.3.12 
    @types/react-dom: ^18.3.1 => 18.3.1 
    react: ^18.3.1 => 18.3.1 
    react-dom: ^18.3.1 => 18.3.1

Current Behavior

Currently, when the Dialog is filled with lots of controls it overflows even though it tries to handle it by scrolling at some point. You can see that the heading in the dialog is cut off in the screenshot.
Image

Expected Behavior

Content should stay in its borders

Reproduction

https://stackblitz.com/~/github.com/fruhnow/vitejs-fluentui-test

Steps to reproduce

  1. open repro (use simulator or real device)
  2. see overflow

Are you reporting an Accessibility issue?

None

Suggested severity

Urgent - No workaround and Products/sites are affected

Products/sites affected

No response

Are you willing to submit a PR to fix?

no

Validations

  • Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
  • The provided reproduction is a minimal reproducible example of the bug.
@spmonahan
Copy link
Contributor

I'm not able to repro in Edge:

Image

Is there a specific browser or size I should be targetting?

@fruhnow
Copy link
Author

fruhnow commented Dec 3, 2024

Thanks for the feedback!

As mentioned in the repro-steps: i can not reproduce this in any desktop-browser (be it chromium-based or whatever) as well. This happens on real devices (iPhones) or iOS Simulators (i should have been more clear on simulators not being the devtools but the iOS Simulators from XCode) in Safari and Chrome (probably other browsers as well).

Hope this helps. Feel free to reach out if there is anything unclear still.

Thank you in Advance!

@spmonahan
Copy link
Contributor

@microsoft/cxe-prg I need someone with a Mac to take a look at this for triage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants