Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix(tokens): ensure teams tokens follow teams overrides for fonts #33393

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

bugfix(tokens): ensure teams tokens follow teams overrides for fonts #33393

wants to merge 1 commit into from
+29 −3

Conversation

bsunderhus
Copy link
Contributor

@bsunderhus bsunderhus commented Dec 3, 2024 •
edited
Loading

Previous Behavior

Fluent Teams tokens gives preference for Segoe UI font family instead of local system font -apple-system, BlinkMacSystemFont. This is causing inconsistencies between Teams and Teams embedded applications, as they consume those token from different sources.

New Behavior

Updates the fontFamilyBase token to give preference for -apple-system, BlinkMacSystemFont as that is the default fonts being used on Teams

Related Issue(s)

@bsunderhus bsunderhus self-assigned this Dec 3, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 3, 2024 •
edited
Loading

📊 Bundle size report

Package & Exports Baseline (minified/GZIP) PR Change
react-components
react-components: entire library		 1.164 MB
291.602 kB		 1.164 MB
291.681 kB		 169 B
79 B
react-theme
Teams: all themes		 35.666 kB
7.453 kB		 35.835 kB
7.512 kB		 169 B
59 B
react-theme
Teams: Light theme		 19.642 kB
5.549 kB		 19.794 kB
5.602 kB		 152 B
53 B
Unchanged fixtures
Package & Exports Size (minified/GZIP)
global-context
createContext		 510 B
328 B
global-context
createContextSelector		 537 B
339 B
react-accordion
Accordion (including children components)		 106.71 kB
32.714 kB
react-aria
ARIA - Default		 237 B
181 B
react-avatar
Avatar		 49.303 kB
15.815 kB
react-avatar
AvatarGroup		 20.106 kB
7.968 kB
react-avatar
AvatarGroupItem		 63.447 kB
20.034 kB
react-badge
Badge		 25.954 kB
8.595 kB
react-badge
CounterBadge		 26.733 kB
8.872 kB
react-badge
PresenceBadge		 25.719 kB
9.457 kB
react-breadcrumb
@fluentui/react-breadcrumb - package		 114.291 kB
31.695 kB
react-button
Button		 37.174 kB
10.803 kB
react-button
CompoundButton		 43.588 kB
12.101 kB
react-button
MenuButton		 41.989 kB
12.144 kB
react-button
SplitButton		 50.006 kB
13.716 kB
react-button
ToggleButton		 53.107 kB
12.561 kB
react-calendar-compat
Calendar Compat		 150.095 kB
40.026 kB
react-card
Card - All		 101.77 kB
28.772 kB
react-card
Card		 94.544 kB
26.951 kB
react-card
CardFooter		 14.355 kB
5.79 kB
react-card
CardHeader		 16.888 kB
6.669 kB
react-card
CardPreview		 14.42 kB
5.922 kB
react-checkbox
Checkbox		 35.118 kB
12.077 kB
react-combobox
Combobox (including child components)		 104.401 kB
34.205 kB
react-combobox
Dropdown (including child components)		 105.025 kB
34.13 kB
react-components
react-components: Button, FluentProvider & webLightTheme		 69.21 kB
20.174 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover		 220.62 kB
63.913 kB
react-components
react-components: FluentProvider & webLightTheme		 44.447 kB
14.59 kB
react-datepicker-compat
DatePicker Compat		 224.187 kB
63.434 kB
react-dialog
Dialog (including children components)		 100.276 kB
30.064 kB
react-divider
Divider		 21.328 kB
7.953 kB
react-field
Field		 23.399 kB
8.898 kB
react-image
Image		 15.36 kB
6.236 kB
react-input
Input		 28.014 kB
9.444 kB
react-jsx-runtime
Classic Pragma		 1.057 kB
530 B
react-jsx-runtime
JSX Dev Runtime		 3.771 kB
1.643 kB
react-jsx-runtime
JSX Runtime		 4.367 kB
1.874 kB
react-label
Label		 14.671 kB
5.99 kB
react-link
Link		 17.326 kB
7.032 kB
react-list-preview
List		 89.164 kB
26.599 kB
react-list-preview
ListItem		 112.731 kB
33.432 kB
react-menu
Menu (including children components)		 152.683 kB
46.128 kB
react-menu
Menu (including selectable components)		 155.364 kB
46.61 kB
react-message-bar
MessageBar (all components)		 24.878 kB
9.264 kB
react-motion
@fluentui/react-motion - createMotionComponent()		 4.293 kB
1.895 kB
react-motion
@fluentui/react-motion - createPresenceComponent()		 5.024 kB
2.226 kB
react-motion
@fluentui/react-motion - PresenceGroup		 1.714 kB
819 B
react-overflow
hooks only		 12.808 kB
4.819 kB
react-persona
Persona		 56.194 kB
17.695 kB
react-popover
Popover		 128.926 kB
40.326 kB
react-portal
Portal		 14.563 kB
5.118 kB
react-portal-compat
PortalCompatProvider		 8.39 kB
2.64 kB
react-positioning
usePositioning		 27.079 kB
9.71 kB
react-progress
ProgressBar		 17.084 kB
6.891 kB
react-provider
FluentProvider		 24.623 kB
8.893 kB
react-radio
Radio		 32.672 kB
10.343 kB
react-radio
RadioGroup		 15.762 kB
6.423 kB
react-select
Select		 27.732 kB
10.124 kB
react-slider
Slider		 37.52 kB
12.621 kB
react-spinbutton
SpinButton		 36.06 kB
11.815 kB
react-spinner
Spinner		 25.245 kB
8.539 kB
react-swatch-picker
@fluentui/react-swatch-picker - package		 105.086 kB
30.516 kB
react-switch
Switch		 35.319 kB
11.314 kB
react-table
DataGrid		 161.034 kB
45.71 kB
react-table
Table (Primitives only)		 42.666 kB
13.854 kB
react-table
Table as DataGrid		 131.869 kB
36.57 kB
react-table
Table (Selection only)		 70.536 kB
19.999 kB
react-table
Table (Sort only)		 69.179 kB
19.61 kB
react-tag-picker
@fluentui/react-tag-picker - package		 184.105 kB
55.426 kB
react-tags
InteractionTag		 15.199 kB
6.157 kB
react-tags
Tag		 29.072 kB
9.55 kB
react-tags
TagGroup		 82.719 kB
24.524 kB
react-teaching-popover
TeachingPopover		 90.633 kB
27.604 kB
react-text
Text - Default		 17.061 kB
6.723 kB
react-text
Text - Wrappers		 20.242 kB
7.048 kB
react-textarea
Textarea		 26.572 kB
9.755 kB
react-theme
Single theme token import		 69 B
89 B
react-timepicker-compat
TimePicker		 107.39 kB
35.763 kB
react-toast
Toast (including Toaster)		 98.326 kB
29.588 kB
react-tooltip
Tooltip		 55.917 kB
19.611 kB
react-tree
FlatTree		 145.092 kB
41.692 kB
react-tree
PersonaFlatTree		 145.78 kB
41.805 kB
react-tree
PersonaTree		 142.011 kB
40.622 kB
react-tree
Tree		 141.323 kB
40.519 kB
react-utilities
SSRProvider		 180 B
160 B
🤖 This report was generated against 3027a9370d46b4e9ee9791d901e9123782aa9a8b

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 3, 2024

Pull request demo site: URL

fabricteam
fabricteam reviewed Dec 3, 2024
View reviewed changes
change/@fluentui-tokens-a1396b99-e2b7-4ab3-8c89-7d58c5b4ba8b.json
@@ -0,0 +1,7 @@
{
Copy link
Collaborator

@fabricteam fabricteam Dec 3, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕵🏾‍♀️ visual regressions to review in the fluentui-web-components-v3 Visual Regression Report

Accordion 4 screenshots
Image Name Diff(in Pixels) Image Type
Accordion.Disabled Dark Mode.chromium.png 2617 Changed
Accordion.Accordion With Custom Icons Dark Mode.chromium.png 1109 Changed
Accordion.Marker Position End Dark Mode.chromium.png 2302 Changed
Accordion.Size Dark Mode.chromium.png 9027 Changed
Avatar 4 screenshots
Image Name Diff(in Pixels) Image Type
Avatar.Active Dark Mode.chromium.png 13 Changed
Avatar.Active Appearance Dark Mode.chromium.png 23 Changed
Avatar.Color Dark Mode.chromium.png 614 Changed
Avatar.Colorful Dark Mode.chromium.png 270 Changed
Badge 4 screenshots
Image Name Diff(in Pixels) Image Type
Badge.Size Dark Mode.chromium.png 89 Changed
Badge.Color Dark Mode.chromium.png 2459 Changed
Badge.Shape Dark Mode.chromium.png 17 Changed
Badge.Appearance Dark Mode.chromium.png 472 Changed
Button 15 screenshots
Image Name Diff(in Pixels) Image Type
Button.Medium With Icon Dark Mode.chromium.png 746 Changed
Button.Outline Dark Mode.chromium.png 224 Changed
Button.Large With Icon Dark Mode.chromium.png 941 Changed
Button.Outline Disabled Dark Mode.chromium.png 55 Changed
Button.Outline Disabled Focusable Dark Mode.chromium.png 55 Changed
Button.Small With Icon Dark Mode.chromium.png 332 Changed
Button.Primary Disabled Focusable Dark Mode.chromium.png 74 Changed
Button.Primary Dark Mode.chromium.png 171 Changed
Button.Subtle Dark Mode.chromium.png 162 Changed
Button.Subtle Disabled Dark Mode.chromium.png 50 Changed
Button.Primary Disabled Dark Mode.chromium.png 74 Changed
Button.Subtle Disabled Focusable Dark Mode.chromium.png 50 Changed
Button.Transparent Disabled Dark Mode.chromium.png 77 Changed
Button.Transparent Dark Mode.chromium.png 256 Changed
Button.Transparent Disabled Focusable Dark Mode.chromium.png 77 Changed
Divider 4 screenshots
Image Name Diff(in Pixels) Image Type
Divider.Appearance Subtle Dark Mode.chromium.png 68 Changed
Divider.Appearance Brand Dark Mode.chromium.png 44 Changed
Divider.Appearance Default Dark Mode.chromium.png 101 Changed
Divider.Appearance Strong Dark Mode.chromium.png 101 Changed
Label 3 screenshots
Image Name Diff(in Pixels) Image Type
Label.Default Dark Mode.chromium.png 144 Changed
Label.Disabled Dark Mode.chromium.png 46 Changed
Label.Required Dark Mode.chromium.png 166 Changed
MenuList 4 screenshots
Image Name Diff(in Pixels) Image Type
MenuList.Checkbox Dark Mode.chromium.png 269 Changed
MenuList.With Submenu Dark Mode.chromium.png 269 Changed
MenuList.Radio Dark Mode.chromium.png 269 Changed
MenuList.Default Dark Mode.chromium.png 117 Changed
ProgressBar 1 screenshots
Image Name Diff(in Pixels) Image Type
ProgressBar.Default Dark Mode.chromium.png 1789 Changed
Tabs 8 screenshots
Image Name Diff(in Pixels) Image Type
Tabs.Default Dark Mode.chromium.png 1083 Changed
Tabs.Size Medium Vertical Dark Mode.chromium.png 914 Changed
Tabs.Size Large Vertical Dark Mode.chromium.png 1131 Changed
Tabs.Size Medium Dark Mode.chromium.png 1083 Changed
Tabs.Size Small Vertical Dark Mode.chromium.png 914 Changed
Tabs.Size Small Dark Mode.chromium.png 1075 Changed
Tabs.Size Large Dark Mode.chromium.png 1387 Changed
Tabs.Disabled Dark Mode.chromium.png 312 Changed
TextInput 10 screenshots
Image Name Diff(in Pixels) Image Type
TextInput.Appearance Filled Darker Dark Mode.chromium.png 377 Changed
TextInput.Appearance Filled Lighter Dark Mode.chromium.png 374 Changed
TextInput.Appearance Outline Dark Mode.chromium.png 446 Changed
TextInput.Appearance Underline Dark Mode.chromium.png 355 Changed
TextInput.Content Start Dark Mode.chromium.png 227 Changed
TextInput.Content End Dark Mode.chromium.png 216 Changed
TextInput.Content Start End Dark Mode.chromium.png 532 Changed
TextInput.Placeholder Dark Mode.chromium.png 662 Changed
TextInput.Disabled Dark Mode.chromium.png 300 Changed
TextInput.Required Dark Mode.chromium.png 275 Changed

fabricteam
fabricteam reviewed Dec 3, 2024
View reviewed changes
change/@fluentui-tokens-a1396b99-e2b7-4ab3-8c89-7d58c5b4ba8b.json
@@ -0,0 +1,7 @@
{
Copy link
Collaborator

@fabricteam fabricteam Dec 3, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕵🏾‍♀️ visual regressions to review in the fluentuiv9 Visual Regression Report

Accordion Converged 3 screenshots
Image Name Diff(in Pixels) Image Type
Accordion Converged.Visibility Focus High Contrast.chromium.png 588 Changed
Accordion Converged.Expand Icon Icon High Contrast.chromium.png 1366 Changed
Accordion Converged.Disabled High Contrast.chromium.png 1200 Changed
Avatar Converged 5 screenshots
Image Name Diff(in Pixels) Image Type
Avatar Converged.Color Active High Contrast.chromium.png 1155 Changed
Avatar Converged.badgeMask.chromium.png 3 Changed
Avatar Converged.Color High Contrast.chromium.png 1155 Changed
Avatar Converged.Basic High Contrast.chromium.png 102 Changed
Avatar Converged.Badge Mask RTL.chromium.png 13 Changed
AvatarGroup Converged 7 screenshots
Image Name Diff(in Pixels) Image Type
AvatarGroup Converged.Layout Pie 1 High Contrast.chromium.png 1094 Changed
AvatarGroup Converged.Layout Stack High Contrast.chromium.png 4683 Changed
AvatarGroup Converged.Layout Pie 2 High Contrast.chromium.png 1094 Changed
AvatarGroup Converged.Layout Pie High Contrast.chromium.png 1094 Changed
AvatarGroup Converged.Basic High Contrast.chromium.png 4730 Changed
AvatarGroup Converged.Overflow Content High Contrast.chromium.png 219 Changed
AvatarGroup Converged.Overflow Indicator High Contrast.chromium.png 2768 Changed
Badge Converged 4 screenshots
Image Name Diff(in Pixels) Image Type
Badge Converged.Filled High Contrast.chromium.png 10827 Changed
Badge Converged.Ghost High Contrast.chromium.png 7209 Changed
Badge Converged.Outline High Contrast.chromium.png 11257 Changed
Badge Converged.Tint High Contrast.chromium.png 7914 Changed
Breadcrumb Converged 1 screenshots
Image Name Diff(in Pixels) Image Type
Breadcrumb Converged.Appearance High Contrast.chromium.png 3030 Changed
Button Converged 9 screenshots
Image Name Diff(in Pixels) Image Type
Button Converged.Primary Disabled High Contrast.chromium.png 264 Changed
Button Converged.Outline Disabled High Contrast.chromium.png 315 Changed
Button Converged.Default High Contrast.chromium.png 479 Changed
Button Converged.Subtle High Contrast.chromium.png 402 Changed
Button Converged.Disabled High Contrast.chromium.png 315 Changed
Button Converged.Subtle Disabled High Contrast.chromium.png 264 Changed
Button Converged.Primary High Contrast.chromium.png 871 Changed
Button Converged.Transparent Disabled High Contrast.chromium.png 264 Changed
Button Converged.Transparent High Contrast.chromium.png 402 Changed
Card Converged 1 screenshots
Image Name Diff(in Pixels) Image Type
Card Converged.Appearance High Contrast.chromium.png 20333 Changed
Card Converged - Interactive 4 screenshots
Image Name Diff(in Pixels) Image Type
Card Converged - Interactive.Appearance Interactive Filled Alternative High Contrast.chromium.png 12374 Changed
Card Converged - Interactive.Appearance Interactive Filled High Contrast.chromium.png 12374 Changed
Card Converged - Interactive.Appearance Interactive Outline High Contrast.chromium.png 12254 Changed
Card Converged - Interactive.Appearance Interactive Subtle High Contrast.chromium.png 12254 Changed
Card Converged - Selectable 4 screenshots
Image Name Diff(in Pixels) Image Type
Card Converged - Selectable.Appearance Selectable Filled Alternative High Contrast.chromium.png 12374 Changed
Card Converged - Selectable.Appearance Selectable Subtle High Contrast.chromium.png 12254 Changed
Card Converged - Selectable.Appearance Selectable Filled High Contrast.chromium.png 12374 Changed
Card Converged - Selectable.Appearance Selectable Outline High Contrast.chromium.png 12254 Changed
DatePicker Compat 4 screenshots
Image Name Diff(in Pixels) Image Type
DatePicker Compat.Date Range Month Hight Contrast.chromium.png 1878 Changed
DatePicker Compat.Default Hight Contrast.chromium.png 175 Changed
DatePicker Compat.Marked Dates Hight Contrast.chromium.png 1878 Changed
DatePicker Compat.Show Week Numbers Hight Contrast.chromium.png 1960 Changed
Dialog 11 screenshots
Image Name Diff(in Pixels) Image Type
Dialog.Alert High Contrast.chromium.png 22010 Changed
Dialog.Actions Position Start Position End High Contrast.chromium.png 23262 Changed
Dialog.Default High Contrast.chromium.png 22010 Changed
Dialog.Actions Position Start High Contrast.chromium.png 22001 Changed
Dialog.Nested High Contrast.chromium.png 3544 Changed
Dialog.No Actions High Contrast.chromium.png 17483 Changed
Dialog.No Title High Contrast.chromium.png 20678 Changed
Dialog.No Title No Actions High Contrast.chromium.png 16151 Changed
Dialog.Non Modal High Contrast.chromium.png 25737 Changed
Dialog.Scroll Long Content High Contrast.chromium.png 79153 Changed
Dialog.Title Custom Action High Contrast.chromium.png 18250 Changed
Divider Converged - Horizontal 4 screenshots
Image Name Diff(in Pixels) Image Type
Divider Converged - Horizontal.Appearance Subtle High Contrast.chromium.png 95 Changed
Divider Converged - Horizontal.Appearance Brand High Contrast.chromium.png 95 Changed
Divider Converged - Horizontal.Appearance Strong High Contrast.chromium.png 95 Changed
Divider Converged - Horizontal.With Content High Contrast.chromium.png 95 Changed
Drawer 20 screenshots
Image Name Diff(in Pixels) Image Type
Drawer.Full Inline High Contrast.chromium.png 2005 Changed
Drawer.Alert Overlay High Contrast.chromium.png 1684 Changed
Drawer.Default High Contrast.chromium.png 1684 Changed
Drawer.Full Overlay High Contrast.chromium.png 1684 Changed
Drawer.Inline High Contrast.chromium.png 2005 Changed
Drawer.Large Content Scroll Inline High Contrast.chromium.png 20606 Changed
Drawer.Large Content Scroll Overlay High Contrast.chromium.png 1684 Changed
Drawer.Large Inline High Contrast.chromium.png 2005 Changed
Drawer.Large Overlay High Contrast.chromium.png 1684 Changed
Drawer.Medium Overlay High Contrast.chromium.png 1684 Changed
Drawer.Medium Inline High Contrast.chromium.png 2005 Changed
Drawer.Non Modal Overlay High Contrast.chromium.png 1684 Changed
Drawer.Separator Position End Inline High Contrast.chromium.png 6682 Changed
Drawer.Position Start Overlay High Contrast.chromium.png 1684 Changed
Drawer.Position End Overlay High Contrast.chromium.png 1684 Changed
Drawer.Position End Inline High Contrast.chromium.png 6682 Changed
Drawer.Position Start Inline High Contrast.chromium.png 6682 Changed
Drawer.overlay drawer full.chromium.png 7 Changed
Drawer.Overlay High Contrast.chromium.png 1684 Changed
Drawer.Separator Position Start Inline High Contrast.chromium.png 6682 Changed
InfoLabel 1 screenshots
Image Name Diff(in Pixels) Image Type
InfoLabel.Default High Contrast.chromium.png 497 Changed
InteractionTag Converged 7 screenshots
Image Name Diff(in Pixels) Image Type
InteractionTag Converged.Brand High Contrast.chromium.png 478 Changed
InteractionTag Converged.Brand Disabled High Contrast.chromium.png 314 Changed
InteractionTag Converged.Default High Contrast.chromium.png 365 Changed
InteractionTag Converged.Disabled High Contrast.chromium.png 314 Changed
InteractionTag Converged.Filled High Contrast.chromium.png 478 Changed
InteractionTag Converged.Outline High Contrast.chromium.png 478 Changed
InteractionTag Converged.Outline Disabled High Contrast.chromium.png 314 Changed
Label Converged 3 screenshots
Image Name Diff(in Pixels) Image Type
Label Converged.Disabled High Contrast.chromium.png 313 Changed
Label Converged.Root High Contrast.chromium.png 247 Changed
Label Converged.Required High Contrast.chromium.png 476 Changed
Link Converged - Rendered as anchor 4 screenshots
Image Name Diff(in Pixels) Image Type
Link Converged - Rendered as anchor.Inverted Disabled High Contrast.chromium.png 601 Changed
Link Converged - Rendered as anchor.Inverted High Contrast.chromium.png 677 Changed
Link Converged - Rendered as anchor.Stand Alone High Contrast.chromium.png 329 Changed
Link Converged - Rendered as anchor.Stand Alone Disabled Focusable High Contrast.chromium.png 558 Changed
Link Converged - Rendered as button 2 screenshots
Image Name Diff(in Pixels) Image Type
Link Converged - Rendered as button.Inverted High Contrast.chromium.png 677 Changed
Link Converged - Rendered as button.Inverted Disabled High Contrast.chromium.png 601 Changed
Link Converged - Rendered as span 2 screenshots
Image Name Diff(in Pixels) Image Type
Link Converged - Rendered as span.Inverted High Contrast.chromium.png 677 Changed
Link Converged - Rendered as span.Inverted Disabled High Contrast.chromium.png 601 Changed
Menu Converged - groups 1 screenshots
Image Name Diff(in Pixels) Image Type
Menu Converged - groups.Default High Contrast.chromium.png 1049 Changed
Menu Converged - selection 2 screenshots
Image Name Diff(in Pixels) Image Type
Menu Converged - selection.Switch High Contrast.chromium.png 1498 Changed
Menu Converged - selection.Checkbox High Contrast.chromium.png 175 Changed
MessageBar 1 screenshots
Image Name Diff(in Pixels) Image Type
MessageBar.Intents High Contrast.chromium.png 8649 Changed
Persona Converged 1 screenshots
Image Name Diff(in Pixels) Image Type
Persona Converged.Basic High Contrast.chromium.png 1351 Changed
Radio Converged 4 screenshots
Image Name Diff(in Pixels) Image Type
Radio Converged.Disabled Checked High Contrast.chromium.png 273 Changed
Radio Converged.Checked High Contrast.chromium.png 168 Changed
Radio Converged.Disabled High Contrast.chromium.png 143 Changed
Radio Converged.Unchecked High Contrast.chromium.png 259 Changed
RatingDisplay Converged 3 screenshots
Image Name Diff(in Pixels) Image Type
RatingDisplay Converged.Brand With Half Value High Contrast.chromium.png 70 Changed
RatingDisplay Converged.Marigold With Half Value High Contrast.chromium.png 70 Changed
RatingDisplay Converged.Neutral With Half Value High Contrast.chromium.png 70 Changed
SpinButton Converged 10 screenshots
Image Name Diff(in Pixels) Image Type
SpinButton Converged.Appearance Outline Default High Contrast.chromium.png 142 Changed
SpinButton Converged.At Min Bound High Contrast.chromium.png 137 Changed
SpinButton Converged.At Max Bound High Contrast.chromium.png 137 Changed
SpinButton Converged.Appearance Filled Lighter High Contrast.chromium.png 115 Changed
SpinButton Converged.Appearance Filled Darker High Contrast.chromium.png 142 Changed
SpinButton Converged.Size Small High Contrast.chromium.png 43 Changed
SpinButton Converged.Appearance Underline High Contrast.chromium.png 84 Changed
SpinButton Converged.Display Value High Contrast.chromium.png 264 Changed
SpinButton Converged.Custom Width High Contrast.chromium.png 59 Changed
SpinButton Converged.Disabled High Contrast.chromium.png 93 Changed
Spinner converged 2 screenshots
Image Name Diff(in Pixels) Image Type
Spinner converged.Inverted With Label High Contrast.chromium.png 1450 Changed
Spinner converged.Primary With Label High Contrast.chromium.png 1450 Changed
SwatchPicker Converged 1 screenshots
Image Name Diff(in Pixels) Image Type
SwatchPicker Converged.Default High Contrast.chromium.png 1198 Changed
Switch Converged 4 screenshots
Image Name Diff(in Pixels) Image Type
Switch Converged.Disabled And Unchecked High Contrast.chromium.png 540 Changed
Switch Converged.Disabled And Checked High Contrast.chromium.png 540 Changed
Switch Converged.Enabled And Checked High Contrast.chromium.png 636 Changed
Switch Converged.Enabled And Unchecked High Contrast.chromium.png 636 Changed
TabList and Tab Converged 10 screenshots
Image Name Diff(in Pixels) Image Type
TabList and Tab Converged.Filled Circular Appearance High Contrast.chromium.png 775 Changed
TabList and Tab Converged.Large Size High Contrast.chromium.png 640 Changed
TabList and Tab Converged.Small Size High Contrast.chromium.png 485 Changed
TabList and Tab Converged.Vertical And Large Size High Contrast.chromium.png 560 Changed
TabList and Tab Converged.Vertical And Small Size High Contrast.chromium.png 420 Changed
TabList and Tab Converged.Tab Selected Default High Contrast.chromium.png 593 Changed
TabList and Tab Converged.Subtle Appearance High Contrast.chromium.png 485 Changed
TabList and Tab Converged.Subtle Circular Appearance High Contrast.chromium.png 1105 Changed
TabList and Tab Converged.Tab Selected High Contrast.chromium.png 593 Changed
TabList and Tab Converged.Default High Contrast.chromium.png 485 Changed
Table layout flex 10 screenshots
Image Name Diff(in Pixels) Image Type
Table layout flex.Multiselect Checked Neutral High Contrast.chromium.png 5312 Changed
Table layout flex.Multiselect Checked Brand High Contrast.chromium.png 7282 Changed
Table layout flex.Multiselect High Contrast Story.chromium.png 7282 Changed
Table layout flex.Multiselect Mixed Brand High Contrast.chromium.png 7282 Changed
Table layout flex.Single Select Checked Brand High Contrast.chromium.png 7282 Changed
Table layout flex.Size Medium High Contrast Story.chromium.png 7282 Changed
Table layout flex.Multiselect Mixed Neutral High Contrast.chromium.png 6190 Changed
Table layout flex.Single Select Checked High Contrast Story.chromium.png 7282 Changed
Table layout flex.Single Select High Contrast Story.chromium.png 7282 Changed
Table layout flex.Single Select Checked Neutral High Contrast.chromium.png 6671 Changed
Table layout flex - cell actions 2 screenshots
Image Name Diff(in Pixels) Image Type
Table layout flex - cell actions.Always Visible High Contrast.chromium.png 7282 Changed
Table layout flex - cell actions.Default High Contrast.chromium.png 7282 Changed
Table layout flex - headers 1 screenshots
Image Name Diff(in Pixels) Image Type
Table layout flex - headers.Sortable High Contrast.chromium.png 7346 Changed
Table layout table 10 screenshots
Image Name Diff(in Pixels) Image Type
Table layout table.Multiselect Checked Neutral High Contrast.chromium.png 5312 Changed
Table layout table.Multiselect High Contrast Story.chromium.png 7282 Changed
Table layout table.Multiselect Checked Brand High Contrast.chromium.png 7282 Changed
Table layout table.Multiselect Mixed Brand High Contrast.chromium.png 7282 Changed
Table layout table.Single Select Checked Brand High Contrast.chromium.png 7282 Changed
Table layout table.Single Select Checked Neutral High Contrast.chromium.png 6671 Changed
Table layout table.Multiselect Mixed Neutral High Contrast.chromium.png 6190 Changed
Table layout table.Single Select Checked High Contrast Story.chromium.png 7282 Changed
Table layout table.Size Medium High Contrast Story.chromium.png 7282 Changed
Table layout table.Single Select High Contrast Story.chromium.png 7282 Changed
Table layout table - cell actions 2 screenshots
Image Name Diff(in Pixels) Image Type
Table layout table - cell actions.Always Visible High Contrast.chromium.png 7282 Changed
Table layout table - cell actions.Default High Contrast.chromium.png 7282 Changed
Table layout table - headers 1 screenshots
Image Name Diff(in Pixels) Image Type
Table layout table - headers.Sortable High Contrast.chromium.png 7346 Changed
Tag Converged 7 screenshots
Image Name Diff(in Pixels) Image Type
Tag Converged.Brand Disabled High Contrast.chromium.png 274 Changed
Tag Converged.Filled High Contrast.chromium.png 417 Changed
Tag Converged.Outline Disabled High Contrast.chromium.png 274 Changed
Tag Converged.Brand High Contrast.chromium.png 417 Changed
Tag Converged.Default High Contrast.chromium.png 365 Changed
Tag Converged.Outline High Contrast.chromium.png 417 Changed
Tag Converged.Disabled High Contrast.chromium.png 274 Changed
TagPicker 7 screenshots
Image Name Diff(in Pixels) Image Type
TagPicker.Appearance High Contrast.chromium.png 6355 Changed
TagPicker.Expand Icon High Contrast.chromium.png 242 Changed
TagPicker.Default Open High Contrast.chromium.png 5619 Changed
TagPicker.Disabled High Contrast.chromium.png 1673 Changed
TagPicker.Grouped High Contrast.chromium.png 5619 Changed
TagPicker.Secondary Action High Contrast.chromium.png 386 Changed
TagPicker.Size High Contrast.chromium.png 798 Changed
Text Converged 1 screenshots
Image Name Diff(in Pixels) Image Type
Text Converged.Default High Contrast.chromium.png 26567 Changed
ToggleButton Converged 2 screenshots
Image Name Diff(in Pixels) Image Type
ToggleButton Converged.Default High Contrast.chromium.png 479 Changed
ToggleButton Converged.Primary High Contrast.chromium.png 871 Changed
Tooltip Converged 2 screenshots
Image Name Diff(in Pixels) Image Type
Tooltip Converged.Basic High Contrast.chromium.png 374 Changed
Tooltip Converged.With Arrow High Contrast.chromium.png 516 Changed
Tree 11 screenshots
Image Name Diff(in Pixels) Image Type
Tree.Default High Contrast.chromium.png 972 Changed
Tree.Actions High Contrast.chromium.png 648 Changed
Tree.Appearance High Contrast.chromium.png 1319 Changed
Tree.Expand Icon High Contrast.chromium.png 1966 Changed
Tree.Default Open Tree High Contrast.chromium.png 2966 Changed
Tree.Flat High Contrast.chromium.png 267 Changed
Tree.Flat Tree Multi Selection High Contrast.chromium.png 353 Changed
Tree.Flat Tree Single Selection High Contrast.chromium.png 353 Changed
Tree.Persona High Contrast.chromium.png 3855 Changed
Tree.Size High Contrast.chromium.png 2484 Changed
Tree.Layout High Contrast.chromium.png 670 Changed

@bsunderhus bsunderhus force-pushed the tokens/bugfix--ensure-teams-tokens-follow-teams-overrides-for-fonts branch from 7b44163 to 5d942ed Compare December 3, 2024 14:03
@bsunderhus bsunderhus marked this pull request as ready for review December 4, 2024 07:51
@bsunderhus bsunderhus requested a review from a team as a code owner December 4, 2024 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabricteam fabricteam fabricteam left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@bsunderhus bsunderhus

Labels
Area: Fonts
Projects
None yet
Milestone
December Project Cycle Q4 2024
Development

Successfully merging this pull request may close these issues.

[Bug]: Teams fonts are inconsistent across embedded platforms due to overrides on Teams
2 participants
@bsunderhus @fabricteam