Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Carousel: Set CarouselNav totalSlides to controlled #33453

Merged
merged 4 commits into from
Dec 11, 2024
Merged

Carousel: Set CarouselNav totalSlides to controlled #33453

merged 4 commits into from
Dec 11, 2024

Conversation

Mitch-At-Work
Copy link
Contributor

Previous Behavior

CarouselNav totalSlides prop was only used to initialize state

New Behavior

totalSlides prop now controls state without preventing undefined default behaviour

Related Issue(s)

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 11, 2024 •
edited
Loading

📊 Bundle size report

Package & Exports Baseline (minified/GZIP) PR Change
react-components
react-components: entire library		 1.165 MB
291.712 kB		 1.165 MB
291.698 kB		 -21 B
-14 B
Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-components
react-components: Button, FluentProvider & webLightTheme		 69.21 kB
20.174 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover		 221.351 kB
64.017 kB
react-components
react-components: FluentProvider & webLightTheme		 44.447 kB
14.59 kB
react-portal-compat
PortalCompatProvider		 8.39 kB
2.64 kB
react-timepicker-compat
TimePicker		 107.39 kB
35.763 kB
🤖 This report was generated against c142edc1617943b7745f66398893a04c90be16e9

@github-actions GitHub Actions
Copy link

Pull request demo site: URL

@Mitch-At-Work Mitch-At-Work marked this pull request as ready for review December 11, 2024 23:05
@Mitch-At-Work Mitch-At-Work requested review from a team as code owners December 11, 2024 23:05
@Mitch-At-Work Mitch-At-Work merged commit 1175ab2 into microsoft:master Dec 11, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabricteam fabricteam fabricteam left review comments

@mltejera mltejera mltejera approved these changes

Assignees
No one assigned
Labels
Component: Carousel
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: CarouselNav does not properly re-render when totalSlides prop is changed
3 participants
@Mitch-At-Work @fabricteam @mltejera