Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build errors when repo folder path has spaces #7508

Closed
ecraig12345 opened this issue Jan 2, 2019 · 1 comment
Closed

Build errors when repo folder path has spaces #7508

ecraig12345 opened this issue Jan 2, 2019 · 1 comment

Comments

@ecraig12345
Copy link
Member

ecraig12345 commented Jan 2, 2019

Repro steps

  1. Make a folder with a space in the name, such as D:\some folder
  2. Clone the Fabric Git repo into that folder
  3. cd into the folder and npm run build

There will be a build error about the path D:\some not existing.

(This was initially filed under #7442 but root cause investigation/fix was moved to this issue per @micahgodbolt's request.)

Investigation

One issue is with the way install-run-rush.js spawns Rush in a child process, and I have a fix for that at microsoft/rushstack#1003. This affects both Windows and Mac.

There's also some issue with either Fabric's build scripts or one of their dependencies--the failure to build set-version occurs during the Jest step, but I'm still working on figuring out why. This only affects Windows.

@ecraig12345
Copy link
Member Author

Closing this since we're no longer using Rush.

@microsoft microsoft locked as resolved and limited conversation to collaborators Sep 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant