pkg/guid: make code windows-only #193
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When attempting to update go modules in a project, "go get" failed, because the
pkg/guid package contained Windows-only code, but was not marked as "windows-only",
resulting in the following error:
GO111MODULE=on go get github.com/Microsoft/[email protected]
....
package github.com/Microsoft/hcsshim
imports github.com/Microsoft/go-winio/pkg/guid
imports golang.org/x/sys/windows: build constraints exclude all Go files in /go/pkg/mod/golang.org/x/[email protected]/windows
This patch marks the code as "windows-only", excluding it from other platforms.
A "doc.go" file was added so that the package is not considered "empty" on other
platforms.
Signed-off-by: Sebastiaan van Stijn <[email protected]>
|
Oh! I see #191 appears to be fixing the same issue (but didn't add a |
|
Right, so there's indeed other packages that have the same problem. I'll comment on that PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relates to microsoft/hcsshim#941 (comment) and microsoft/hcsshim#942
When attempting to update go modules in a project, "go get" failed, because the pkg/guid package contained Windows-only code, but was not marked as "windows-only", resulting in the following error:
This patch marks the code as "windows-only", excluding it from other platforms. A "doc.go" file was added so that the package is not considered "empty" on other platforms.