Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github-ci: use go1.19.x #1689

Merged
merged 2 commits into from
Mar 13, 2023
Merged

github-ci: use go1.19.x #1689

merged 2 commits into from
Mar 13, 2023

Conversation

anmaxvl
Copy link
Contributor

@anmaxvl anmaxvl commented Mar 9, 2023

No description provided.

@anmaxvl anmaxvl marked this pull request as ready for review March 9, 2023 07:43
@anmaxvl anmaxvl requested a review from a team as a code owner March 9, 2023 07:43
@helsaawy
Copy link
Contributor

helsaawy commented Mar 9, 2023

I ran into this issue a while ago: go1.19 changes the go-doc formatting, specifically with spacing around code blocks.
Basically you need to re-run the proto generation with go 1.19

@katiewasnothere
Copy link
Contributor

Is there a reason that we're moving to 1.19 and not to 1.20 since that's already out?

@anmaxvl
Copy link
Contributor Author

anmaxvl commented Mar 9, 2023

Is there a reason that we're moving to 1.19 and not to 1.20 since that's already out?

I just wanted to get to a minimal version that's required for containerd to run. currently it's failing to build, which I should've probably put in the PR description.

rerun protobuild

Signed-off-by: Maksim An <[email protected]>
@helsaawy
Copy link
Contributor

I forgot about the other issue:
https://go.dev/doc/go1.19#os-exec-path
exec.LookPath now fails to find stuff in the local path and returns a wrapped exec.ErrDot (https://pkg.go.dev/os/exec#LookPath):

path, err := exec.LookPath(command)
if err != nil {
// LookPath only finds current directory matches based on the
// callers current directory but the caller is not likely in the
// same directory as the containerd executables. Instead match the
// calling binaries path (a containerd shim usually) and see if they
// are side by side. If so execute the runhcs.exe found there.
if self, serr := os.Executable(); serr == nil {
testPath := filepath.Join(filepath.Dir(self), command)
if _, serr := os.Stat(testPath); serr == nil {
path = testPath
}
}
if path == "" {
// Failed to look up command just use it directly and let the
// Windows loader find it.
path = command
}
runhcsPath.Store(path)
return path
}

@anmaxvl anmaxvl merged commit 66fe5f7 into microsoft:main Mar 13, 2023
@anmaxvl anmaxvl deleted the github-ci-bump-go branch March 13, 2023 17:33
helsaawy added a commit that referenced this pull request Sep 8, 2023
rerun protobuild

fix: check for `exec.ErrDot`

Signed-off-by: Maksim An <[email protected]>
(cherry picked from commit 66fe5f7)
Signed-off-by: Hamza El-Saawy <[email protected]>
helsaawy added a commit that referenced this pull request Sep 8, 2023
rerun protobuild

fix: check for `exec.ErrDot`


(cherry picked from commit 66fe5f7)

Signed-off-by: Maksim An <[email protected]>
Signed-off-by: Hamza El-Saawy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants