Add computestorage syscalls so we can base RS5 wclayer on it. #407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jterry75
commented
Dec 1, 2018
| // == OsLayerTypeVm`. | ||
| // | ||
| // `options` are the options applied while processing the layer. | ||
| func HcsSetupBaseOSLayer(layerPath string, vhdHandle syscall.Handle, options OsLayerOptions) error { |
There was a problem hiding this comment.
@jstarks - Should we make these paths at this layer and then open the handles ourselves? Or should we make the caller do it. I can go either way both have +/-.
Signed-off-by: Justin Terry (VM) <[email protected]>
Signed-off-by: Justin Terry (VM) <[email protected]>
jterry75
force-pushed
the
syscall_computestorage
branch
from
caf11b5
to
6499cd1
Compare
|
Closing for now. Will leave the branch |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
internal/computestorageexports that are callable by internal packages.